This PR was merged into the 2.x branch.
Discussion
----------
modified code to use variadics when possible
Commits
-------
a002d59 modified code to use variadics when possible
This PR was merged into the 1.x branch.
Discussion
----------
add a comma to clarify the meaning
Without the comma you could understand that the "if" not only applied
to `-1`, but to `1` as well if you read too quickly.
Commits
-------
7cd3c9d add a comma to clarify the meaning
This PR was squashed before being merged into the 1.x branch (closes#2308).
Discussion
----------
added PHP CS Fixer config
Commits
-------
aa9604a added PHP CS Fixer config
aa71a65 fixed CS
This PR was merged into the 2.x branch.
Discussion
----------
drop PHP 5.x support
Commits
-------
b6761e1 removed old C extension
747d7be dropped PHP 5.x support
12e7545 fix travis build matrix to support 7.x and hhvm
This PR was merged into the 1.x branch.
Discussion
----------
deprecate function/test/filter/tag overriding
closes#2293
Commits
-------
7ffb188 deprecated function/test/filter/tag overriding
* 1.x:
Sync PHP ext with PHP code to trigger deprecations
deprecated the "disable_c_ext" attribute on Twig_Node_Expression_GetAttr
removed ltrim because $class variable already ltrim'ed
Remove argument type from ExpressionParser constructor
bumped version to 1.29.1-DEV
prepared the 1.29.0 release
This PR was merged into the 1.x branch.
Discussion
----------
deprecate the "disable_c_ext" attribute on Twig_Node_Expression_GetAttr
Commits
-------
c215966 Sync PHP ext with PHP code to trigger deprecations
014ab1f deprecated the "disable_c_ext" attribute on Twig_Node_Expression_GetAttr
This PR was merged into the 1.x branch.
Discussion
----------
removed ltrim because $class variable already ltrim'ed
removed ltrim because $class variable already ltrim'ed
Commits
-------
3badb14 removed ltrim because $class variable already ltrim'ed
This PR was merged into the 1.x branch.
Discussion
----------
Remove $env argument type from ExpressionParser constructor
Either the argument type should be removed, or the whole "else" block and the deprecation warning is useless.
Commits
-------
3de96ef Remove argument type from ExpressionParser constructor
This PR was merged into the 1.x branch.
Discussion
----------
Fix sandbox being left enabled if an exception is thrown while rendering
What's happening for me:
- An exception is thrown while rendering inside the sandbox
- Render exception response
- WebProfiler toolbar tries to include a file
- Sandbox is still enabled, so a SecurityException is thrown (which hides the real error)
Commits
-------
171a1d4 Fix sandbox being left enabled if an exception is thrown while rendering with include function
This PR was merged into the 2.x branch.
Discussion
----------
Cleanups
Minor cleanup (getTemplateName is deprecated in 1.x)
Commits
-------
b8dabf6 Cleanups
This PR was merged into the 1.x branch.
Discussion
----------
Cleanup
Two things here:
guessTemplateInfo is private in 2.x
this PR will fix tests on 2.x
setTemplateName is deprecated, and the removed code paths are never run
Commits
-------
782102d Cleanup