This PR was squashed before being merged into the 2.0-dev branch (closes#1708).
Discussion
----------
Bugfix/constructor should not have optional loader
Following #1693 and the fact that "hasLoader" contains semantical error that loader is optional, this PR removes optionality of loader from Environment.
Commits
-------
ac2295c Bugfix/constructor should not have optional loader
This PR was merged into the 2.0-dev branch.
Discussion
----------
moved protected to private
Moved some protected properties/methods from protected to private.
I've changed protected properties/methods mostly on internal classes but not where it could potentially break BC too badly with existing code.
Classes where we could change protected to private but where it could be a problem for existing code:
* Twig_ExpressionParser
* Twig_Environment
* Twig_Lexer
* Twig_Node
* Twig_Parser (done in second commit)
* Twig_Template
closes#1645
Commits
-------
56a3791 moved protected to private (more)
dbd0c91 moved protected to private
This PR was merged into the 2.0-dev branch.
Discussion
----------
Remove reference to `String` loader in docs
Commits
-------
02a7bd6 Remove reference to `String` loader in docs
This PR was merged into the 2.0-dev branch.
Discussion
----------
Add Twig_ExistsLoaderInterface back for 1.x BC layer #1644
This is the 2.x change for 1.x BC layer of Twig_ExistsLoaderInterface for #1644
Commits
-------
3e546c9 Add Twig_ExistsLoaderInterface back for 1.x BC layer
This PR was merged into the 2.0-dev branch.
Discussion
----------
Fix the profiler node visitor signature for Twig 2.0
Commits
-------
e66b07d Fix the profiler node visitor signature for Twig 2.0
This PR was merged into the 2.0-dev branch.
Discussion
----------
Twig_Template::getContext() removal
`Twig_Template::getContext()` is an implementation detail as it is only used on some PHP versions, for some cases. But even with the big warning in the phpdoc, people want to use it, which is a really bad idea. Removing it in 1.x would be kind of a "BC break", so I propose to remove it in 2.0.
Commits
-------
a0261e7 removed code that people want to overide over and over again
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#1666).
Discussion
----------
add ignore_missing agrument to source function
This basically works the same way as `ignore_missing` on the `include` function/tag.
Commits
-------
afa9358 add ignore_missing agrument to source function
* 1.x:
fixed edge case where tests would fail because of a cache issue
tweaked docs to avoid using an internal method in an example
deprecated Twig_Environment::clearTemplateCache()
fixed sandbox disabling when using the include function
Example about how to rename several blocks
fixed docs
Update batch filter docs with arguments
This PR was merged into the 1.x branch.
Discussion
----------
fixed sandbox disabling when using the include function
closes#1668
Commits
-------
af72894 fixed sandbox disabling when using the include function
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#1720).
Discussion
----------
Example about how to rename several blocks
It was unclear to me how to rename more than 1 imported block. I had to look into the source code to find that, so I add it to the documentation.
Commits
-------
8af1355 Example about how to rename several blocks
This PR was merged into the 1.x branch.
Discussion
----------
fix batch filter with zero items
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
also added a test for preserving keys behavior
Commits
-------
8d6be28 fix batch filter with zero items
This PR was merged into the 1.x branch.
Discussion
----------
Fix PHP_FE_END value
See explanation on rev c41d305
Commits
-------
a1eee07 Fix PHP_FE_END value
Fabien Potencier
Nikola Svitlica a.k.a. TheCelavi
Bocharsky Victor
Shaun
Christophe Coevoet
Valeriy Trubachev
Pierre-Yves Guerder
Alexey Malihin
Tobias Schultze
Remi Collet