This PR was merged into the 1.x branch.
Discussion
----------
[v1] Fixed counting children of SimpleXMLElement object
It works correctly in v1.32 and since v1.33 it is not working correctly.
See: https://github.com/twigphp/Twig/compare/v1.32.0...v1.33.0#diff-d7378002f67a61c458c1de0468eef74fR1265
Test code:
```php
$xml = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?><doc><elem/><elem/></doc>');
var_dump($xml instanceof \Countable);
echo 'Count: ' . count($xml), PHP_EOL;
echo 'Strlen: ' . strlen($xml), PHP_EOL;
echo 'MB Strlen: ' . mb_strlen($xml), PHP_EOL;
```
Results:
```
bool(false)
Count: 2
Strlen: 0
MB Strlen: 0
```
https://3v4l.org/VvUXG
Commits
-------
4a23bdc3 Fixed counting children of SimpleXMLElement object
This PR was merged into the 1.x branch.
Discussion
----------
Add missing else clause to avoid infinite loops
Commits
-------
de2be6a0 added missing else clause to avoid infinite loops
This PR was merged into the 1.x branch.
Discussion
----------
Fix .. (range operator) in sandbox policy
Closes#2630
Commits
-------
6f45fcf5 fixed .. (range operator) in sandbox policy
This PR was squashed before being merged into the 1.x branch (closes#2647).
Discussion
----------
Fix profiler unicity when several ones are registered
Closes#2627, closes#2643, alternative to #2645
What happens is that both Twig and Symfony register a Twig profiler. Unfortunately, the current code does assign the same variable for both profiler, which means that trying to close it twice does not work.
Commits
-------
0ee096f0 fixed test
7b2bdbe3 fixed profiler unicity when several ones are registered
This PR was merged into the 1.x branch.
Discussion
----------
Switch the PHP ext jobs to a whitelist rather than a blacklist
Any new PHP version added in the future will be a PHP 7.x one, not a 5.x one, and so should not have a job for the extension.
the whitelist is already shorter than the blacklist today (3 whitelisted vs 4 blacklisted before, as PHP 5.3 is already handled separately due to precise anyway)
Commits
-------
738f17bb Switch the PHP ext jobs to a whitelist rather than a blacklist
This PR was squashed before being merged into the 1.x branch (closes#2637).
Discussion
----------
Fix C ext
Commits
-------
bffc117f simplified code
a0c24242 fixed C ext
64e85689 fixed Travis config
This PR was squashed before being merged into the 1.x branch (closes#2411).
Discussion
----------
Exception for use of "===" instead of "same as"
As mentioned in #2358
Hope this is the right location for this Exception
Commits
-------
194d51a4 Exception for use of "===" instead of "same as"
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2633).
Discussion
----------
Update .travis.yml to test on PHP 7.2
Commits
-------
8e7527ec Update .travis.yml
This PR was merged into the 1.x branch.
Discussion
----------
Fix possible array to string conversion concealing actual error
This is a 1.x branch backport of #2613
Commits
-------
7ba3b5a5 Fix possible array to string conversion concealing actual error
This PR was merged into the 1.x branch.
Discussion
----------
Make variable names deterministic
Variables should be deterministic to support reproducible builds as outlined in https://github.com/symfony/symfony/issues/25958
Commits
-------
6ab5fe9b Make variable names deterministic
This PR was merged into the 1.x branch.
Discussion
----------
Be able to count on iterator
This PR allows to count on `\Traversable` Objects. Not sure if I made the change to the correct branch. Tell me please if I should target 2.x or master.
Commits
-------
be2c32cc Be able to count on iterator
This PR was merged into the 1.x branch.
Discussion
----------
English tweak contents -> content
The most minor PR ever :).
Made to the 1.x branch, also applies to 2.x obviously.
Commits
-------
19e3fb8c contents -> content
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2611).
Discussion
----------
Update license year
TO DO:
- [x] Wait to the next year (100% done, depends on timezone)
- [ ] Merge!
:octocat:
Commits
-------
012ca796 Update license year
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2598).
Discussion
----------
Update advanced.rst
I noticed that the rot13Provider wasn't called correctly as it was trying to access a local variable instead of calling $this
Commits
-------
b42fd643 Update advanced.rst
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2586).
Discussion
----------
Environment::resolveTemplate now accepts instances of TemplateWrapper
The [documentation on the include function](https://twig.symfony.com/doc/2.x/functions/include.html) states (on the template expression):
> And if the expression evaluates to a Twig_Template or a Twig_TemplateWrapper instance, Twig will use it directly […]
This is currently broken, as `twig_include` [relies on `resolveTemplate`](https://github.com/twigphp/Twig/blob/31b577863b5ae8d19e2cefd174e95a433f16491f/lib/Twig/Extension/Core.php#L1304), which doesn't handle instances of `TemplateWrapper`. This PR fixes that.
For the sake of completeness: the `include` tag doesn't have this problem, as it relies on the `loadTemplate` method of the `Template` class which _does_ handle this case.
Commits
-------
78a4f2fb Environment::resolveTemplate now accepts instances of TemplateWrapper
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2562).
Discussion
----------
Change typo in documentation
In example of use for test_iterable function there is a typo
Commits
-------
8607f13d Change typo in documentation
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2570).
Discussion
----------
fix grammar
Commits
-------
d4309898 fix grammar
This PR was merged into the 1.x branch.
Discussion
----------
Fix PHP 5.3 Travis build
PHP 5.3 is only supported on Debian Precise.
Commits
-------
3a45bd48 Fix PHP 5.3 build
Fabien Potencier
webimpress
Christophe Coevoet
sgotre
Mponos George
Matěj Humpál
Lars Strojny
ARTACK WebLab
Miguel Piedrafita
Ryan Weaver
Peter Fisher
Victor Welling
Asier Ramos
Chris Wright
Christian Schmidt