This PR was merged into the 1.x branch.
Discussion
----------
deprecated the ability to store non Node instances in Node::$nodes
Commits
-------
03f18b4 enforced Node:: to only contain node instances
This PR was merged into the 1.x branch.
Discussion
----------
changed the way we store node filenames
Commits
-------
4c4657a changed the way we store node filenames
This PR was merged into the 1.x branch.
Discussion
----------
deprecated some more methods on Twig_Environment
These methods are sometimes misused (#2020) when called from a template context (Twig_Template::getEnv() has been deprecated as well, but #2106 might re-introduce it).
Anyway, Twig_Environment should not act as a container, so, being able to change the defaults make sense, but retrieving them probably not.
Commits
-------
e548cbe deprecated some more methods on Twig_Environment
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Twig_Compiler::getFilename()
Using `Twig_Compiler::getFilename()` is very fragile as depending on when it is called, the returned value can be very different (depending on template compilation that can have occurred in between).
see #2020 for such a wrong usage.
Commits
-------
1f41e9f deprecated Twig_Compiler::getFilename()
This PR was merged into the 1.x branch.
Discussion
----------
changed a test to make it more robust
Commits
-------
ec7a1c1 changed a test to make it more robust
This PR was squashed before being merged into the 1.x branch (closes#2105).
Discussion
----------
Floor - use cast and not intval
Use cast in fav. of the `inval`, because;
- its faster
- cannot be overloaded
- less chars
Commits
-------
39d46ac Floor - use cast and not intval
This PR was merged into the 1.x branch.
Discussion
----------
Fix static callable.
fixes https://github.com/twigphp/Twig/issues/2053
Commits
-------
8f6fd57 Fix exception message for static method and object without req. params.
This PR was merged into the 1.x branch.
Discussion
----------
[DOC] add named macro end-tag documentation
Hello!
Just discover endmacro tag supports name, just like block.
But it is not mentionned in the doc.
So here's a PR
Commits
-------
dcc5f45 add named macro end-tag documentation
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2090).
Discussion
----------
Do not mix indention levels
Not sure if this was intentional, but the "if" line had an indention of 3 spaces,
while the "true" line has an indention of 4 spaces.
Commits
-------
507f697 Do not mix indention levels
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2080).
Discussion
----------
Add Visual Studio Code to the list of IDE integrations
With the "TWIG pack" extension.
Commits
-------
e8b16c0 Add Visual Studio Code to the list of IDE integrations
This PR was squashed before being merged into the 1.x branch (closes#2087).
Discussion
----------
Fixed all deprecation notices by using `getMockBuilder`
Fixes deprecation notices on PHPUnit 5.4 without using 5.4 specific features.
Commits
-------
17e0caa Fixed all deprecation notices by using
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2076).
Discussion
----------
[Doc] Fixed small error in code example
*see changes*
Commits
-------
dc798d3 [Doc] Fixed small error in code example
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2065).
Discussion
----------
Update macro.rst
Small grammar fix: subject-verb agreement "Macros differ" vs "Macros differs"
Commits
-------
0800545 Update macro.rst
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2066).
Discussion
----------
Update use.rst
Small grammar fix.
Commits
-------
08c830a Update use.rst
This PR was squashed before being merged into the 1.x branch (closes#2043).
Discussion
----------
Fix load cache
In PHP7 @ do not works and it is resource expensive, switching to if statement.
Commits
-------
b5df3d1 Fix load cache
This PR was merged into the 1.x branch.
Discussion
----------
fix a case where the autoescaping does not work as expected
The Twig_NodeVisitor_Escaper collects a list of blocks for all templates that it visits. If you define the same block (i.e. with the same name) in txt and html templates this results sometimes in the html block not being escapes.
This is illustrated in the added test.
To fix it, I propose to reset the list of the blocks for each module.
Alternatively we need to make clear that blocks should not share names between text and html templates.
Commits
-------
48a3487 Reset blocks also in doLeaveNode
ee6965e fix a case where the autoescaping does not work as expected
The Twig_NodeVisitor_Escaper collects a list of blocks for all templates that it visits. If you define the same block (i.e. with the same name) in txt and html templates this results sometimes in the html block not being escapes.
This is illustrated in the added test.
To fix it, I propose to reset the list of the blocks for each module.
Alternatively we need to make clear that blocks should not share names between text and html templates.
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2044).
Discussion
----------
Small fixes
Commits
-------
e81e698 Small fixes
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2029).
Discussion
----------
Grammar
A few grammatical fixes.
Commits
-------
6dd784a Grammar
Fabien Potencier
SpacePossum
Grégoire Paris
Svante Richter
Sam Mousa
Thomas Schulz
Aaron Wallentine
JakeFr
Javier Feria
Javier Eguiluz
Uwe Jäger
Sam
Owen Kieffer-Jones
