This PR was merged into the 1.x branch.
Discussion
----------
Switch the PHP ext jobs to a whitelist rather than a blacklist
Any new PHP version added in the future will be a PHP 7.x one, not a 5.x one, and so should not have a job for the extension.
the whitelist is already shorter than the blacklist today (3 whitelisted vs 4 blacklisted before, as PHP 5.3 is already handled separately due to precise anyway)
Commits
-------
738f17bb Switch the PHP ext jobs to a whitelist rather than a blacklist
This PR was squashed before being merged into the 1.x branch (closes#2637).
Discussion
----------
Fix C ext
Commits
-------
bffc117f simplified code
a0c24242 fixed C ext
64e85689 fixed Travis config
This PR was squashed before being merged into the 1.x branch (closes#2411).
Discussion
----------
Exception for use of "===" instead of "same as"
As mentioned in #2358
Hope this is the right location for this Exception
Commits
-------
194d51a4 Exception for use of "===" instead of "same as"
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2633).
Discussion
----------
Update .travis.yml to test on PHP 7.2
Commits
-------
8e7527ec Update .travis.yml
This PR was merged into the 1.x branch.
Discussion
----------
Fix possible array to string conversion concealing actual error
This is a 1.x branch backport of #2613
Commits
-------
7ba3b5a5 Fix possible array to string conversion concealing actual error
This PR was merged into the 1.x branch.
Discussion
----------
Make variable names deterministic
Variables should be deterministic to support reproducible builds as outlined in https://github.com/symfony/symfony/issues/25958
Commits
-------
6ab5fe9b Make variable names deterministic
This PR was merged into the 1.x branch.
Discussion
----------
Be able to count on iterator
This PR allows to count on `\Traversable` Objects. Not sure if I made the change to the correct branch. Tell me please if I should target 2.x or master.
Commits
-------
be2c32cc Be able to count on iterator
This PR was merged into the 1.x branch.
Discussion
----------
English tweak contents -> content
The most minor PR ever :).
Made to the 1.x branch, also applies to 2.x obviously.
Commits
-------
19e3fb8c contents -> content
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2611).
Discussion
----------
Update license year
TO DO:
- [x] Wait to the next year (100% done, depends on timezone)
- [ ] Merge!
:octocat:
Commits
-------
012ca796 Update license year
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2598).
Discussion
----------
Update advanced.rst
I noticed that the rot13Provider wasn't called correctly as it was trying to access a local variable instead of calling $this
Commits
-------
b42fd643 Update advanced.rst
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2586).
Discussion
----------
Environment::resolveTemplate now accepts instances of TemplateWrapper
The [documentation on the include function](https://twig.symfony.com/doc/2.x/functions/include.html) states (on the template expression):
> And if the expression evaluates to a Twig_Template or a Twig_TemplateWrapper instance, Twig will use it directly […]
This is currently broken, as `twig_include` [relies on `resolveTemplate`](https://github.com/twigphp/Twig/blob/31b577863b5ae8d19e2cefd174e95a433f16491f/lib/Twig/Extension/Core.php#L1304), which doesn't handle instances of `TemplateWrapper`. This PR fixes that.
For the sake of completeness: the `include` tag doesn't have this problem, as it relies on the `loadTemplate` method of the `Template` class which _does_ handle this case.
Commits
-------
78a4f2fb Environment::resolveTemplate now accepts instances of TemplateWrapper
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes#2562).
Discussion
----------
Change typo in documentation
In example of use for test_iterable function there is a typo
Commits
-------
8607f13d Change typo in documentation
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2570).
Discussion
----------
fix grammar
Commits
-------
d4309898 fix grammar
This PR was merged into the 1.x branch.
Discussion
----------
Fix PHP 5.3 Travis build
PHP 5.3 is only supported on Debian Precise.
Commits
-------
3a45bd48 Fix PHP 5.3 build
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2557).
Discussion
----------
add throws tags doc block for Twig_Environment:load
On an internal project review we noticed that `\Twig_Environment::load` is not providing throw tags. As this method is just a proxy for `\Twig_Environment::loadTemplate` which itself is _internal_ we had some discussion around.
this PR provides same throw tags as _loadTemplate_. Maybe this helps to understand code usage
Commits
-------
882c7aab add throws tags doc block for Twig_Environment:load
This PR was merged into the 1.x branch.
Discussion
----------
Added pssibility to reset the profiler
In order to implement symfony/symfony#18244 properly, I needed the ability to reset a Twig profile.
Commits
-------
ea922bb6 Added pssibility to reset the profiler.
This PR was merged into the 1.x branch.
Discussion
----------
Ensure that the "use" TokenParser returns a node instance
Alternative to #2539, fixes#2538.
Commits
-------
421d8722 ensured that the use TokenParser returns a node instance
This PR was squashed before being merged into the 1.x branch (closes#2544).
Discussion
----------
simplified tests as min version if now 5.3.3
fixes#2526
Commits
-------
a3548a6e fixed CS
90a07d16 simplified tests as min version if now 5.3.3