This PR was merged into the 1.x branch.
Discussion
----------
Fix Parser contract for some implementations
Commits
-------
fe6df56e fixed Parser contract for some implementations
This PR was merged into the 1.x branch.
Discussion
----------
Tweak macro docs
closes#2344
Error message were improved a while ago, and this PR makes the documentation clearer about the expectations.
Commits
-------
7446a6d8 tweaked macro docs
This PR was merged into the 1.x branch.
Discussion
----------
Fix in test to support Twig_Markup instances
closes#1512 (extracted from #1768)
Commits
-------
8f00576e fixed in test to support Twig_Markup instances
This PR was merged into the 1.x branch.
Discussion
----------
Fix import macros from a template string
closes#2946
Commits
-------
f0c58854 fixed import macros from a template string
This PR was merged into the 1.x branch.
Discussion
----------
Add a note about escaping
closes#2623, closes#2661
Commits
-------
a83f7e85 added a note about escaping
This PR was merged into the 1.x branch.
Discussion
----------
Fix Lexer when using custom options containing the # char
closes#2948
Commits
-------
7b5851fe fixed Lexer when using custom options containing the # char
This PR was merged into the 1.x branch.
Discussion
----------
Fix compat with NodeInterface
/cc @stof
Commits
-------
701d8af6 fixed compat with NodeInterface
This PR was squashed before being merged into the 1.x branch (closes#2935).
Discussion
----------
Add missing hints in some runtime exceptions
Commits
-------
094df799 added more tests
d4db9153 added missing hints in some runtime exceptions
This PR was merged into the 1.x branch.
Discussion
----------
Make escaping on ternary expressions more fine-grained
closes#2146closes#449closes#539closes#1174closes#1320closes#1739closes#1333
Commits
-------
dfa94113 made escaping on ternary expressions more fine-grained
This PR was merged into the 1.x branch.
Discussion
----------
Fix the "with" behavior to always include the globals
closes#2377
Commits
-------
5db54551 fixed the "with" behavior to always include the globals
This PR was merged into the 1.x branch.
Discussion
----------
Tweak twig_to_array
I've change `twig_to_array()` to **not** cast to an array. That should not be a problem as we almost always call `twig_test_iterable()` before calling `twig_to_array()` and for the cases where it was not done, the PHP code would not work anyway.
follow-up to #2901 and #2909, /cc @thewilkybarkid
Commits
-------
8dd8d0dc tweaked twig_to_array
This PR was merged into the 1.x branch.
Discussion
----------
Prepare for the new serialization mechanism
#eufossa
related to https://github.com/symfony/symfony/pull/30965
So we are future proof and it will prevent deprecations for https://github.com/symfony/symfony/issues/30304.
Almost future proof actually because the void return type cannot be added in 7.0. I guess we can see the minimum required PHP version here once 7.4 is out and see how we can handle compatibility 😕
Commits
-------
72d7abe1 Prepare for the new serialization mechanism
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2928).
Discussion
----------
Disable xdebug var_dump overload for tests
#eufossa
This test template https://github.com/twigphp/Twig/blob/1.x/test/Twig/Tests/Fixtures/tags/sandbox/array.test depends on the `dump` Twig function that depends of `var_dump` PHP function.
If you have xdebug on your local machine, the default value of the `xdebug.overload_var_dump` setting is at `2`. That makes `var_dump` displays the file and the line number of where the `var_dump` was called, making the assertion fail.
Commits
-------
8edd9540 Disable xdebug var_dump overload for tests
Fabien Potencier
Fabien Potencier
Christian Flothmann
Thomas Landauer
fancyweb