Commits
-------
0cb37ba Fix typehint "int" to "integer"
Discussion
----------
Fix typehint "int" to "integer"
---------------------------------------------------------------------------
by nikic at 2012-07-09T21:13:48Z
Why would you want to do that?
---------------------------------------------------------------------------
by Adel-E at 2012-07-09T21:21:34Z
Because in this file all @param use integer instead of int
Commits
-------
9229ef3 Removed useless code
Discussion
----------
[Ext] Removed useless code
All init hooks could be bypassed (just return `SUCESS`)
There is no `ini` entries and no globals
Phpinfo automatically get the version when `MINFO` is null
Twig don't work with PHP 4 (ref to `20010901`)
Commits
-------
2c9e26e Fix date_modify filter for PHP 5.2
Discussion
----------
Fix date_modify filter for PHP 5.2
The return of the object was added in 5.3, this hopefully fixes it.
Commits
-------
ae85586 Add docs for date_modify
0366cf6 Fix docs of date filter
Discussion
----------
Date modify filter
This is probably possible via `date(foo)|modify('-1day')|format()`, but it's non obvious and a dedicated filter might be a bit more prominent.
---------------------------------------------------------------------------
by fabpot at 2012-06-22T07:01:32Z
Just a quick thought: As it modifies the date, it should probably be a function, not a filter.
---------------------------------------------------------------------------
by stof at 2012-06-22T07:24:52Z
@fabpot Aren't filters meant to transform the value ?
Commits
-------
f840670 clarified documentation of pre_escape option
Discussion
----------
Clarified documentation of pre_escape option
The previous wording could be misunderstood as "tell the filter that the input has already been escaped", which is actually the opposite from how it works.
Commits
-------
459a076 The Compiler outdent method will now only reduce the indentation if it's OK to do so, It moves and modifies the check up above the indentation modification.
Discussion
----------
Compiler outdent step validation moved up and modified
The Compiler outdent method will now only reduce the indentation if it's OK
to do so, It moves and modifies the check up above the indentation modification.
It's a small improvement but saves a wasted decrement of a variable, when you know an exception will be thrown immediately following it.
---------------------------------------------------------------------------
by nikic at 2012-06-07T23:18:00Z
Compared to throwing an exception decrementing a variable has practically no cost ;)
PS: Not saying that the change is bad or something like that, only saying that performance is the wrong reason to do it :)
---------------------------------------------------------------------------
by catchamonkey at 2012-06-07T23:20:23Z
Yeah, there is no performance gain, but the code only executes that which is necessary.
It's like there being no point preparing a response before you know if you are going to send it. (slightly OTT example, but you get what I mean) :)
Tobias Schultze
Fabien Potencier
Adel
Douglas Greenshields
stealth35
Jordi Boggiano
Andreas Hucks
Libert KHE
Adrien Brault
Chris Sedlmayr