This PR was merged into the 1.x branch.
Discussion
----------
Fixing wrong function name in deprecation notice
Commits
-------
0a3d3c7 Fixing wrong function name in deprecation notice
This PR was merged into the 1.x branch.
Discussion
----------
Move tests handling in Twig_ParserExpression instead of Twig_Extension_Core
In my quest to better organize the layers in Twig, I've always find the way we deal with test a bit awkward. This PR moves the code from the Core extension to the Parser, where it belongs, even if if makes hardcoding 'is' and 'is not' twice, but I think SOC is more important here. Especially as I want to remove the `getEnvironment()` from the Parser class at some point. Having everything centralized helps a lot.
Commits
-------
4deb03a deprecated Twig_Parser::getEnvironment()
0d6686e moved tests handling in Twig_ParserExpression instead of Twig_Extension_Core
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Twig_Parser::addHandler() and Twig_Parser::addNodeVisitor()
I don't even understand why these methods are here. It looks like they never had any usage in the core.
Commits
-------
31c444b deprecated Twig_Parser::addHandler() and Twig_Parser::addNodeVisitor()
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Twig_Compiler::addIndentation()
Commits
-------
bc499a4 deprecated Twig_Compiler::addIndentation()
This PR was merged into the 1.x branch.
Discussion
----------
fixed regression when registering two extensions with the same class
fixed#2165
Commits
-------
47432f3 fixed regression when registering two extensions having the same class name
This PR was merged into the 1.x branch.
Discussion
----------
make getSourceContext a requirement for any loader
I'm going to follow the same protocol as for `Twig_ExistsLoaderInterface`.
Commits
-------
21ecba8 made using Twig_SourceContextLoaderInterface required
8c33708 made name required for Twig_Source
This PR was merged into the 1.x branch.
Discussion
----------
fixed the filesystem loader with relative paths
closes#2145
TODO
- [x] document the new `$rootPath` option
- [x] add test with a `$rootPath` different from `getcwd()`
- [x] test the cache key does not vary when `$rootPath` changes
Commits
-------
a343c92 fixed the filesystem loader with relative paths
This PR was merged into the 1.x branch.
Discussion
----------
deprecated not supported behavior
Commits
-------
b38f959 deprecated not supported behavior
This PR was merged into the 1.x branch.
Discussion
----------
rename Twig_Node::getName to getTemplateName and Twig_Node::getFile to getTemplateLine
Commits
-------
39d94df renamed Twig_Node::getLine() to Twig_Node::getTemplateLine()
e231aa5 renamed Twig_Node::getName() to Twig_Node::getTemplateName()
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Twig_Template::getSource() in favor of Twig_Template::getSourceContext()
Commits
-------
7598f27 deprecated Twig_Template::getSource() in favor of Twig_Template::getSourceContext()
This PR was merged into the 1.x branch.
Discussion
----------
Try to rename filename to name where we really mean the template name, not the template path on the filesystem
Commits
-------
d03297e deprecated Twig_Node::getFilename() in favor of Twig_Node::getName()
eb47dc9 got rid of filename when we meant template name
This PR was merged into the 1.x branch.
Discussion
----------
added Twig_Source to hold information about the original template
Alternative to #2170
Commits
-------
6c76583 added Twig_Source to hold information about the original template
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Twig_Error::getTemplateFile() and Twig_Error::setTemplateFile()
Commits
-------
b399ec0 deprecated Twig_Error::getTemplateFile() and Twig_Error::setTemplateFile()
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Parser::getFilename()
The name is misleading as it returns the logical template name and not the proper filesystem path. In #2182, this is then replaced with a proper object. This PR simplifies the code review for #2182 by avoiding the pollution of all the changes in the token parser classes.
Commits
-------
d77f3dd deprecated Parser::getFilename()
Christian Flothmann
Fabien Potencier
Kuba Werłos
Christian Flothmann