This PR was merged into the 2.x branch.
Discussion
----------
moved Twig_Template::getAttribute() to a function
Commits
-------
6405684 moved Twig_Template::getAttribute() to a function
This PR was merged into the 2.x branch.
Discussion
----------
modified code to use variadics when possible
Commits
-------
a002d59 modified code to use variadics when possible
This PR was merged into the 1.x branch.
Discussion
----------
Add a simple Twig_RuntimeLoaderInterface implementation
Next to https://github.com/symfony/symfony/pull/21023
This is related to the BC break reported in symfony/symfony#21008 which has been introduced in symfony/symfony#20093 when decoupling extensions from definitions.
What I propose here is to ease the upgrade to symfony 3.2+ by adding a simple `Twig_RuntimeLoaderInterface` implementation here, useful only when using the twig-bridge outside of the symfony fullstack framework (with the Form component for instance).
Upgrading would be as simple as:
```diff
$twig = new Twig_Environment(...);
$rendererEngine = new TwigRendererEngine(array('form_div_layout.html.twig'), $twig);
- $twig->addExtension(new FormExtension(new TwigRenderer($rendererEngine, $csrfTokenManager)));
+ $twig->addExtension(new FormExtension());
+ $twig->addRuntimeLoader(new Twig_RuntimeLoader(array(TwigRenderer::class => new TwigRenderer($rendererEngine, $csrfTokenManager)));
```
Instead of having to write this runtime loader yourself.
Please see symfony/symfony#21008 for details and a concrete example of how this could help.
Commits
-------
91c8d59 Add a Twig_FactoryRuntimeLoader
This PR was merged into the 1.x branch.
Discussion
----------
add a comma to clarify the meaning
Without the comma you could understand that the "if" not only applied
to `-1`, but to `1` as well if you read too quickly.
Commits
-------
7cd3c9d add a comma to clarify the meaning
This PR was squashed before being merged into the 1.x branch (closes#2308).
Discussion
----------
added PHP CS Fixer config
Commits
-------
aa9604a added PHP CS Fixer config
aa71a65 fixed CS
This PR was merged into the 2.x branch.
Discussion
----------
drop PHP 5.x support
Commits
-------
b6761e1 removed old C extension
747d7be dropped PHP 5.x support
12e7545 fix travis build matrix to support 7.x and hhvm
This PR was merged into the 1.x branch.
Discussion
----------
deprecate function/test/filter/tag overriding
closes#2293
Commits
-------
7ffb188 deprecated function/test/filter/tag overriding
* 1.x:
Sync PHP ext with PHP code to trigger deprecations
deprecated the "disable_c_ext" attribute on Twig_Node_Expression_GetAttr
removed ltrim because $class variable already ltrim'ed
Remove argument type from ExpressionParser constructor
bumped version to 1.29.1-DEV
prepared the 1.29.0 release
This PR was merged into the 1.x branch.
Discussion
----------
deprecate the "disable_c_ext" attribute on Twig_Node_Expression_GetAttr
Commits
-------
c215966 Sync PHP ext with PHP code to trigger deprecations
014ab1f deprecated the "disable_c_ext" attribute on Twig_Node_Expression_GetAttr
This PR was merged into the 1.x branch.
Discussion
----------
removed ltrim because $class variable already ltrim'ed
removed ltrim because $class variable already ltrim'ed
Commits
-------
3badb14 removed ltrim because $class variable already ltrim'ed
This PR was merged into the 1.x branch.
Discussion
----------
Remove $env argument type from ExpressionParser constructor
Either the argument type should be removed, or the whole "else" block and the deprecation warning is useless.
Commits
-------
3de96ef Remove argument type from ExpressionParser constructor