Properly fix sqlite issues (#514)

* Update to latest python

I have odd behaviour with importing sqlite3, which is failing to do. I have no clue why, so I'm trying to update Python to the latest stable to check if it's a Python bug.

* Update aiohttp for python compatibility

* Sligtly lower aiohttp version

* Update pyinstaller to latest stable version

It was failing to build a working executable with the latest python runtime.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -12,7 +12,7 @@ body:
         - label: I have searched existing issues
         - label: This issue is not a duplicate of an existing one
         - label: I have checked the [common issues section in the readme file](https://github.com/SteamDeckHomebrew/decky-loader#-common-issues)
-        - label: I have attached logs to this bug report (failure to include logs will mean your issue will not be responded too).
+        - label: I have attached logs to this bug report (failure to include logs will mean your issue may not be responded to).
 
   - type: textarea
     attributes:

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,5 @@
 blank_issues_enabled: false
 contact_links:
   - name: Steam Deck Homebrew Discord Server
-    url: https://discord.gg/ZU74G2NJzk
+    url: https://decky.xyz/discord
     about: Please ask and answer questions here.

.github/workflows/build.yml

@@ -47,15 +47,15 @@ jobs:
       with:
         node-version: 18
       
-    - name: Set up Python 3.10.2 🐍
+    - name: Set up Python 3.11.4 🐍
       uses: actions/setup-python@v4
       with:
-        python-version: "3.10.2"
+        python-version: "3.11.4"
         
     - name: Install Python dependencies ⬇️
       run: |
         python -m pip install --upgrade pip
-        pip install pyinstaller==5.5
+        pip install pyinstaller==5.13.0
         [ -f requirements.txt ] && pip install -r requirements.txt
 
     - name: Install JS dependencies ⬇️
@@ -69,7 +69,7 @@ jobs:
       run: pnpm run build
 
     - name: Build Python Backend 🛠️
-      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data ./backend/static:/static --add-data ./backend/locales:/locales --add-data ./backend/legacy:/legacy --add-data ./plugin:/plugin ./backend/*.py
+      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data ./backend/static:/static --add-data ./backend/locales:/locales --add-data ./backend/legacy:/legacy --add-data ./plugin:/plugin --hidden-import=sqlite3 ./backend/*.py
         
     - name: Upload package artifact ⬆️
       if: ${{ !env.ACT }}
@@ -97,15 +97,15 @@ jobs:
       with:
         node-version: 18
       
-    - name: Set up Python 3.10.2 🐍
+    - name: Set up Python 3.11.4 🐍
       uses: actions/setup-python@v4
       with:
-        python-version: "3.10.2"
+        python-version: "3.11.4"
         
     - name: Install Python dependencies ⬇️
       run: |
         python -m pip install --upgrade pip
-        pip install pyinstaller==5.5
+        pip install pyinstaller==5.13.0
         pip install -r requirements.txt
 
     - name: Install JS dependencies ⬇️
@@ -119,7 +119,7 @@ jobs:
       run: pnpm run build
 
     - name: Build Python Backend 🛠️
-      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data "./backend/static;/static" --add-data "./backend/locales;/locales" --add-data "./backend/legacy;/legacy" --add-data "./plugin;/plugin" ./backend/main.py
+      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data "./backend/static;/static" --add-data "./backend/locales;/locales" --add-data "./backend/legacy;/legacy" --add-data "./plugin;/plugin" --hidden-import=sqlite3 ./backend/main.py
         
     - name: Upload package artifact ⬆️
       uses: actions/upload-artifact@v3

backend/localplatformlinux.py

@@ -60,6 +60,8 @@ def chown(path : str,  user : UserType = UserType.HOST_USER, recursive : bool =
     return result == 0
 
 def chmod(path : str, permissions : int, recursive : bool = True) -> bool:
+    if _get_effective_user_id() != 0:
+        return True
     result = call(["chmod", "-R", str(permissions), path] if recursive else ["chmod", str(permissions), path])
     return result == 0
 
@@ -191,4 +193,4 @@ def get_unprivileged_user() -> str:
         logger.warn("Unprivileged user is not properly configured. Defaulting to 'deck'")
         user = 'deck'
 
-    return user
+    return user

backend/main.py

@@ -24,7 +24,7 @@ from aiohttp_jinja2 import setup as jinja_setup
 # local modules
 from browser import PluginBrowser
 from helpers import (REMOTE_DEBUGGER_UNIT, csrf_middleware, get_csrf_token,
-                     mkdir_as_user, get_system_pythonpaths)
+                     mkdir_as_user, get_system_pythonpaths, get_effective_user_id)
                      
 from injector import get_gamepadui_tab, Tab, get_tabs, close_old_tabs
 from loader import Loader
@@ -178,6 +178,9 @@ if __name__ == "__main__":
 
         # Required for multiprocessing support in frozen files
         multiprocessing.freeze_support()
+    else:
+      if get_effective_user_id() != 0:
+        logger.warning(f"decky is running as an unprivileged user, this is not officially supported and may cause issues")
 
     # Append the loader's plugin path to the recognized python paths
     sys.path.append(path.join(path.dirname(__file__), "plugin"))

requirements.txt

@@ -1,5 +1,5 @@
-aiohttp==3.8.1
-aiohttp-jinja2==1.5.0
+aiohttp==3.8.4
+aiohttp-jinja2==1.5.1
 aiohttp_cors==0.7.0
 watchdog==2.1.7
-certifi==2022.12.7
+certifi==2022.12.7