[Need Testing] Actually fix sqlite 3 issues (#515)

* Properly fix sqlite issues

* Revert python downgrade

* Horrible hack to update SQLite to the latest version in the Ubuntu VMs

* Cleanup build script

* Fix yaml formatting

* Fix typos

* Use sudo for installing binary

* Fix library path

* Wrong naming

* Wrong name again

* Small stylisting fixes

* Missed a space

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -12,7 +12,7 @@ body:
         - label: I have searched existing issues
         - label: This issue is not a duplicate of an existing one
         - label: I have checked the [common issues section in the readme file](https://github.com/SteamDeckHomebrew/decky-loader#-common-issues)
-        - label: I have attached logs to this bug report (failure to include logs will mean your issue will not be responded too).
+        - label: I have attached logs to this bug report (failure to include logs will mean your issue may not be responded to).
 
   - type: textarea
     attributes:

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,5 @@
 blank_issues_enabled: false
 contact_links:
   - name: Steam Deck Homebrew Discord Server
-    url: https://discord.gg/ZU74G2NJzk
+    url: https://decky.xyz/discord
     about: Please ask and answer questions here.

.github/workflows/build.yml

@@ -31,7 +31,7 @@ permissions:
 jobs:
   build:
     name: Build PluginLoader
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
     - name: Print input
@@ -47,15 +47,32 @@ jobs:
       with:
         node-version: 18
       
-    - name: Set up Python 3.10.2 🐍
+    - name: Set up Python 3.11.4 🐍
       uses: actions/setup-python@v4
       with:
-        python-version: "3.10.2"
-        
+        python-version: "3.11.4"
+    
+    - name: Upgrade SQLite 3 binary version to 3.42.0 🧑‍💻
+      run: >
+        cd /tmp &&
+        wget "https://www.sqlite.org/2023/sqlite-autoconf-3420000.tar.gz" &&
+        tar -xvzf sqlite-autoconf-3420000.tar.gz &&
+        cd /tmp/sqlite-autoconf-3420000 &&
+        ./configure --prefix=/usr --disable-static CFLAGS="-g" CPPFLAGS="$CPPFLAGS -DSQLITE_ENABLE_COLUMN_METADATA=1 \
+          -DSQLITE_ENABLE_UNLOCK_NOTIFY -DSQLITE_ENABLE_DBSTAT_VTAB=1 -DSQLITE_ENABLE_FTS3_TOKENIZER=1 \
+          -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_STMTVTAB -DSQLITE_MAX_VARIABLE_NUMBER=250000 \
+          -DSQLITE_MAX_EXPR_DEPTH=10000 -DSQLITE_ENABLE_MATH_FUNCTIONS" &&
+        make &&
+        sudo make install &&
+        sudo cp /usr/lib/libsqlite3.so /usr/lib/x86_64-linux-gnu/ &&
+        sudo cp /usr/lib/libsqlite3.so.0 /usr/lib/x86_64-linux-gnu/ &&
+        sudo cp /usr/lib/libsqlite3.so.0.8.6 /usr/lib/x86_64-linux-gnu/ &&
+        rm -r /tmp/sqlite-autoconf-3420000
+
     - name: Install Python dependencies ⬇️
       run: |
         python -m pip install --upgrade pip
-        pip install pyinstaller==5.5
+        pip install pyinstaller==5.13.0
         [ -f requirements.txt ] && pip install -r requirements.txt
 
     - name: Install JS dependencies ⬇️
@@ -69,7 +86,7 @@ jobs:
       run: pnpm run build
 
     - name: Build Python Backend 🛠️
-      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data ./backend/static:/static --add-data ./backend/locales:/locales --add-data ./backend/legacy:/legacy --add-data ./plugin:/plugin ./backend/*.py
+      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data ./backend/static:/static --add-data ./backend/locales:/locales --add-data ./backend/legacy:/legacy --add-data ./plugin:/plugin --hidden-import=sqlite3 ./backend/*.py
         
     - name: Upload package artifact ⬆️
       if: ${{ !env.ACT }}
@@ -97,15 +114,15 @@ jobs:
       with:
         node-version: 18
       
-    - name: Set up Python 3.10.2 🐍
+    - name: Set up Python 3.11.4 🐍
       uses: actions/setup-python@v4
       with:
-        python-version: "3.10.2"
+        python-version: "3.11.4"
         
     - name: Install Python dependencies ⬇️
       run: |
         python -m pip install --upgrade pip
-        pip install pyinstaller==5.5
+        pip install pyinstaller==5.13.0
         pip install -r requirements.txt
 
     - name: Install JS dependencies ⬇️
@@ -119,7 +136,7 @@ jobs:
       run: pnpm run build
 
     - name: Build Python Backend 🛠️
-      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data "./backend/static;/static" --add-data "./backend/locales;/locales" --add-data "./backend/legacy;/legacy" --add-data "./plugin;/plugin" ./backend/main.py
+      run: pyinstaller --noconfirm --onefile --name "PluginLoader" --add-data "./backend/static;/static" --add-data "./backend/locales;/locales" --add-data "./backend/legacy;/legacy" --add-data "./plugin;/plugin" --hidden-import=sqlite3 ./backend/main.py
         
     - name: Upload package artifact ⬆️
       uses: actions/upload-artifact@v3

backend/localplatformlinux.py

@@ -60,6 +60,8 @@ def chown(path : str,  user : UserType = UserType.HOST_USER, recursive : bool =
     return result == 0
 
 def chmod(path : str, permissions : int, recursive : bool = True) -> bool:
+    if _get_effective_user_id() != 0:
+        return True
     result = call(["chmod", "-R", str(permissions), path] if recursive else ["chmod", str(permissions), path])
     return result == 0
 
@@ -191,4 +193,4 @@ def get_unprivileged_user() -> str:
         logger.warn("Unprivileged user is not properly configured. Defaulting to 'deck'")
         user = 'deck'
 
-    return user
+    return user

backend/main.py

@@ -24,7 +24,7 @@ from aiohttp_jinja2 import setup as jinja_setup
 # local modules
 from browser import PluginBrowser
 from helpers import (REMOTE_DEBUGGER_UNIT, csrf_middleware, get_csrf_token,
-                     mkdir_as_user, get_system_pythonpaths)
+                     mkdir_as_user, get_system_pythonpaths, get_effective_user_id)
                      
 from injector import get_gamepadui_tab, Tab, get_tabs, close_old_tabs
 from loader import Loader
@@ -178,6 +178,9 @@ if __name__ == "__main__":
 
         # Required for multiprocessing support in frozen files
         multiprocessing.freeze_support()
+    else:
+      if get_effective_user_id() != 0:
+        logger.warning(f"decky is running as an unprivileged user, this is not officially supported and may cause issues")
 
     # Append the loader's plugin path to the recognized python paths
     sys.path.append(path.join(path.dirname(__file__), "plugin"))

frontend/src/components/TitleView.tsx

@@ -49,15 +49,15 @@ const TitleView: VFC = () => {
   }
 
   return (
-    <div className={staticClasses.Title} style={titleStyles}>
+    <Focusable className={staticClasses.Title} style={titleStyles}>
       <DialogButton
         style={{ height: '28px', width: '40px', minWidth: 0, padding: '10px 12px' }}
         onClick={closeActivePlugin}
       >
         <FaArrowLeft style={{ marginTop: '-4px', display: 'block' }} />
       </DialogButton>
-      <div style={{ flex: 0.9 }}>{activePlugin.name}</div>
-    </div>
+      {activePlugin?.titleView || <div style={{ flex: 0.9 }}>{activePlugin.name}</div>}
+    </Focusable>
   );
 };
 

frontend/src/plugin.ts

@@ -5,6 +5,7 @@ export interface Plugin {
   content?: JSX.Element;
   onDismount?(): void;
   alwaysRender?: boolean;
+  titleView?: JSX.Element;
 }
 
 export enum InstallType {

requirements.txt

@@ -1,5 +1,5 @@
-aiohttp==3.8.1
-aiohttp-jinja2==1.5.0
+aiohttp==3.8.4
+aiohttp-jinja2==1.5.1
 aiohttp_cors==0.7.0
 watchdog==2.1.7
-certifi==2022.12.7
+certifi==2022.12.7