geckon01/php-qrcode
1
0
Fork 0
mirror of https://github.com/chillerlan/php-qrcode.git synced 2026-09-01 13:08:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

:octocat: proper overflow test & coverage

Browse Source
This commit is contained in:
codemasher
2020-02-19 20:47:08 +01:00
parent 577e43a2be
commit 2dde546ef9
3 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Data/QRDataAbstract.php
+2 -2
View File
@@ -181,9 +181,9 @@ abstract class QRDataAbstract implements QRDataInterface{
$this->write($data);
// there was an error writing the BitBuffer data, which is... unlikely.
// overflow, likely caused due to invalid version setting
if($this->bitBuffer->length > $MAX_BITS){
throw new QRCodeException(sprintf('code length overflow. (%d > %d bit)', $this->bitBuffer->length, $MAX_BITS)); // @codeCoverageIgnore
throw new QRCodeDataException(sprintf('code length overflow. (%d > %d bit)', $this->bitBuffer->length, $MAX_BITS));
}
// end code.
tests/Data/DatainterfaceTestAbstract.php
+6
View File
@@ -60,4 +60,10 @@ abstract class DatainterfaceTestAbstract extends QRTestAbstract{
$this->getMethod('getMinimumVersion')->invoke($this->dataInterface);
}
public function testCodeLengthOverflowException(){
$this->expectException(QRCodeDataException::class);
$this->expectExceptionMessage('code length overflow');
$this->dataInterface->setData(\str_repeat('0', 1337));
}
}
tests/Data/KanjiTest.php
+8
View File
@@ -49,4 +49,12 @@ class KanjiTest extends DatainterfaceTestAbstract{
$this->dataInterface->setData('Ã');
}
public function testCodeLengthOverflowException(){
$this->expectException(QRCodeDataException::class);
$this->expectExceptionMessage('code length overflow');
$this->dataInterface->setData(\str_repeat('荷', 1337));
}
}