:octocat: remove QRMatrix::flip()

This commit is contained in:
smiley
2023-04-10 15:41:19 +02:00
parent 05e99b8eb8
commit 6c66d56a31
2 changed files with 7 additions and 34 deletions
+7 -14
View File
@@ -282,18 +282,6 @@ class QRMatrix{
return $this;
}
/**
* Flips the value of the module at ($x, $y)
*/
public function flip(int $x, int $y):self{
if(isset($this->matrix[$y][$x])){
$this->matrix[$y][$x] ^= $this::IS_DARK;
}
return $this;
}
/**
* Checks whether the module at ($x, $y) is of the given $M_TYPE
*
@@ -718,8 +706,13 @@ class QRMatrix{
foreach($this->matrix as $y => $row){
foreach($row as $x => $val){
if($mask($x, $y) && ($val & $this::M_DATA) === $this::M_DATA){
$this->flip($x, $y);
// skip non-data modules
if(($val & $this::M_DATA) !== $this::M_DATA){
continue;
}
if($mask($x, $y)){
$this->set($x, $y, ($val & $this::IS_DARK) !== $this::IS_DARK, $val);
}
}
}
-20
View File
@@ -484,26 +484,6 @@ final class QRMatrixTest extends TestCase{
(new QRCode($o))->addByteSegment('testdata')->getQRMatrix()->setLogoSpace(37, 37);
}
/**
* Tests flipping the value of a module
*/
public function testFlip():void{
$this->matrix->set(20, 20, true, QRMatrix::M_TEST);
// cover checkType()
$this::assertTrue($this->matrix->checkType(20, 20, QRMatrix::M_TEST));
// verify the current state (dark)
$this::assertSame(QRMatrix::M_TEST_DARK, $this->matrix->get(20, 20));
// flip
$this->matrix->flip(20, 20);
// verify flip
$this::assertSame(QRMatrix::M_TEST, $this->matrix->get(20, 20));
// flip again
$this->matrix->flip(20, 20);
// verify flip
$this::assertSame(QRMatrix::M_TEST_DARK, $this->matrix->get(20, 20));
}
/**
* Tests checking whether the M_TYPE of a module is not one of an array of M_TYPES
*/