mirror of
https://github.com/predis/predis.git
synced 2026-08-30 20:21:31 +00:00
Fix a bug in Predis\Network\StreamConnection::writeBytes().
When PHP's fwrite() ends up writing only a part of $buffer over the network, this method attempts to automatically write the rest of $buffer. Due to this bug, the data being already sent to the server was not discarded from $buffer. Usually fwrite() writes the whole $buffer in one go, but anyway this bug would not have passed unnoticed since it results in malformed requests and Redis would have surely returned a -ERR reply.
This commit is contained in:
@@ -103,7 +103,7 @@ class StreamConnection extends ConnectionBase {
|
||||
if ($written === false || $written === 0) {
|
||||
$this->onConnectionError('Error while writing bytes to the server');
|
||||
}
|
||||
$value = substr($buffer, $written);
|
||||
$buffer = substr($buffer, $written);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user