Add Support for CF.ADDNX (#1048)

* add support for CF.ADDNX

* fix key name

* fix wrong command
This commit is contained in:
shacharPash
2023-01-31 13:25:48 +02:00
committed by GitHub
parent c57fe5e2b2
commit 0bdfcddcc1
4 changed files with 120 additions and 0 deletions
+1
View File
@@ -60,6 +60,7 @@ use Predis\Command\CommandInterface;
* @method $this bzpopmin(array $keys, int $timeout)
* @method $this bzmpop(int $timeout, array $keys, string $modifier = 'min', int $count = 1)
* @method $this cfadd(string $key, $item)
* @method $this cfaddnx(string $key, $item)
* @method $this cfexists(string $key, $item)
* @method $this decr($key)
* @method $this decrby($key, $decrement)
+1
View File
@@ -69,6 +69,7 @@ use Predis\Response\Status;
* @method array bzpopmin(array $keys, int $timeout)
* @method array bzmpop(int $timeout, array $keys, string $modifier = 'min', int $count = 1)
* @method int cfadd(string $key, $item)
* @method int cfaddnx(string $key, $item)
* @method int cfexists(string $key, $item)
* @method int decr(string $key)
* @method int decrby(string $key, int $decrement)
@@ -0,0 +1,28 @@
<?php
/*
* This file is part of the Predis package.
*
* (c) 2009-2020 Daniele Alessandri
* (c) 2021-2023 Till Krüss
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Predis\Command\Redis\CuckooFilter;
use Predis\Command\Command as RedisCommand;
/**
* @see https://redis.io/commands/cf.addnx/
*
* Adds an item to a cuckoo filter if the item did not exist previously.
*/
class CFADDNX extends RedisCommand
{
public function getId()
{
return 'CF.ADDNX';
}
}
@@ -0,0 +1,90 @@
<?php
/*
* This file is part of the Predis package.
*
* (c) 2009-2020 Daniele Alessandri
* (c) 2021-2023 Till Krüss
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Predis\Command\Redis\CuckooFilter;
use Predis\Command\Redis\PredisCommandTestCase;
use Predis\Response\ServerException;
class CFADDNX_Test extends PredisCommandTestCase
{
/**
* {@inheritDoc}
*/
protected function getExpectedCommand(): string
{
return CFADDNX::class;
}
/**
* {@inheritDoc}
*/
protected function getExpectedId(): string
{
return 'CFADDNX';
}
/**
* @group disconnected
*/
public function testFilterArguments(): void
{
$actualArguments = ['key', 'item'];
$expectedArguments = ['key', 'item'];
$command = $this->getCommand();
$command->setArguments($actualArguments);
$this->assertSameValues($expectedArguments, $command->getArguments());
}
/**
* @group disconnected
*/
public function testParseResponse(): void
{
$this->assertSame(1, $this->getCommand()->parseResponse(1));
}
/**
* @group connected
* @return void
* @requiresRedisBfVersion >= 1.0.0
*/
public function testAddItemToCuckooFilterWhenExists(): void
{
$redis = $this->getClient();
$actualResponse = $redis->cfaddnx('key', 'item');
$this->assertSame(1, $actualResponse);
$this->assertSame(1, $redis->cfexists('key', 'item'));
$actualResponse = $redis->cfaddnx('key', 'item');
$this->assertSame(0, $actualResponse);
$this->assertSame(1, $redis->cfexists('key', 'item'));
}
/**
* @group connected
* @requiresRedisBfVersion >= 1.0.0
*/
public function testThrowsExceptionOnWrongType(): void
{
$this->expectException(ServerException::class);
$this->expectExceptionMessage('Operation against a key holding the wrong kind of value');
$redis = $this->getClient();
$redis->set('cfaddnx_foo', 'bar');
$redis->cfaddnx('cfaddnx_foo', 'foo');
}
}