geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-08-30 20:21:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] Improve assert failure messages for replication stategy tests.

Browse Source
This commit is contained in:
Daniele Alessandri
2015-07-23 11:38:49 +02:00
parent c0d1a74447
commit 15f3b6030c
1 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Predis/Replication/ReplicationStrategyTest.php
+23 -5
View File
@@ -29,7 +29,11 @@ class ReplicationStrategyTest extends PredisTestCase
foreach ($this->getExpectedCommands('read') as $commandId) {
$command = $profile->createCommand($commandId);
$this->assertTrue($strategy->isReadOperation($command));
$this->assertTrue(
$strategy->isReadOperation($command),
"$commandId is expected to be a read operation."
);
}
}
@@ -43,7 +47,11 @@ class ReplicationStrategyTest extends PredisTestCase
foreach ($this->getExpectedCommands('write') as $commandId) {
$command = $profile->createCommand($commandId);
$this->assertFalse($strategy->isReadOperation($command), $commandId);
$this->assertFalse(
$strategy->isReadOperation($command),
"$commandId is expected to be a write operation."
);
}
}
@@ -57,7 +65,11 @@ class ReplicationStrategyTest extends PredisTestCase
foreach ($this->getExpectedCommands('disallowed') as $commandId) {
$command = $profile->createCommand($commandId);
$this->assertTrue($strategy->isDisallowedOperation($command), $commandId);
$this->assertTrue(
$strategy->isDisallowedOperation($command),
"$commandId is expected to be a disallowed operation."
);
}
}
@@ -70,10 +82,16 @@ class ReplicationStrategyTest extends PredisTestCase
$strategy = new ReplicationStrategy();
$cmdReadSort = $profile->createCommand('SORT', array('key:list'));
$this->assertTrue($strategy->isReadOperation($cmdReadSort), 'SORT [read-only]');
$this->assertTrue(
$strategy->isReadOperation($cmdReadSort),
'SORT is expected to be a read operation.'
);
$cmdWriteSort = $profile->createCommand('SORT', array('key:list', array('store' => 'key:stored')));
$this->assertFalse($strategy->isReadOperation($cmdWriteSort), 'SORT [write with STORE]');
$this->assertFalse(
$strategy->isReadOperation($cmdWriteSort),
'SORT with STORE is expected to be a write operation.'
);
}
/**