geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-08-30 04:02:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not use is_numeric() when it is not really needed (it is relatively slow).

Browse Source
This commit is contained in:
Daniele Alessandri
2011-01-13 10:40:58 +01:00
parent fc9deb68be
commit 4e6ed1fd5b
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Predis.php
+10 -10
View File
@@ -1682,14 +1682,13 @@ class ResponseErrorSilentHandler implements IResponseHandler {
}
class ResponseBulkHandler implements IResponseHandler {
public function handle(IConnectionSingle $connection, $length) {
if (!is_numeric($length)) {
public function handle(IConnectionSingle $connection, $lengthString) {
$length = (int) $lengthString;
if ($length != $lengthString) {
Utils::onCommunicationException(new MalformedServerResponse(
$connection, "Cannot parse '$length' as data length"
));
}
$length = (int) $length;
if ($length >= 0) {
return $length > 0 ? substr($connection->readBytes($length + 2), 0, -2) : '';
}
@@ -1700,14 +1699,14 @@ class ResponseBulkHandler implements IResponseHandler {
}
class ResponseMultiBulkHandler implements IResponseHandler {
public function handle(IConnectionSingle $connection, $length) {
if (!is_numeric($length)) {
public function handle(IConnectionSingle $connection, $lengthString) {
$length = (int) $lengthString;
if ($length != $lengthString) {
Utils::onCommunicationException(new MalformedServerResponse(
$connection, "Cannot parse '$length' as data length"
));
}
$length = (int) $length;
if ($length === -1) {
return null;
}
@@ -1734,13 +1733,14 @@ class ResponseMultiBulkHandler implements IResponseHandler {
}
class ResponseMultiBulkStreamHandler implements IResponseHandler {
public function handle(IConnectionSingle $connection, $length) {
if (!is_numeric($length)) {
public function handle(IConnectionSingle $connection, $lengthString) {
$length = (int) $lengthString;
if ($length != $lengthString) {
Utils::onCommunicationException(new MalformedServerResponse(
$connection, "Cannot parse '$length' as data length"
));
}
return new Iterators\MultiBulkResponseSimple($connection, (int) $length);
return new Iterators\MultiBulkResponseSimple($connection, $length);
}
}