mirror of
https://github.com/predis/predis.git
synced 2026-09-19 06:47:39 +00:00
Extended TDigest support by implementing TDIGEST.RESET command (#1104)
* Added support for TDIGEST.RESET command * Codestyle fixes --------- Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>
This commit is contained in:
committed by
GitHub
parent
b38a9f6441
commit
699d023280
@@ -182,6 +182,7 @@ use Predis\Command\CommandInterface;
|
||||
* @method $this tdigestmax(string $key)
|
||||
* @method $this tdigestmin(string $key)
|
||||
* @method $this tdigestrank(string $key, ...$value)
|
||||
* @method $this tdigestreset(string $key)
|
||||
* @method $this zadd($key, array $membersAndScoresDictionary)
|
||||
* @method $this zcard($key)
|
||||
* @method $this zcount($key, $min, $max)
|
||||
|
||||
@@ -192,6 +192,7 @@ use Predis\Response\Status;
|
||||
* @method string tdigestmax(string $key)
|
||||
* @method string tdigestmin(string $key)
|
||||
* @method array tdigestrank(string $key, float ...$value)
|
||||
* @method Status tdigestreset(string $key)
|
||||
* @method string xadd(string $key, array $dictionary, string $id = '*', array $options = null)
|
||||
* @method int xdel(string $key, string ...$id)
|
||||
* @method int xlen(string $key)
|
||||
|
||||
@@ -0,0 +1,28 @@
|
||||
<?php
|
||||
|
||||
/*
|
||||
* This file is part of the Predis package.
|
||||
*
|
||||
* (c) 2009-2020 Daniele Alessandri
|
||||
* (c) 2021-2023 Till Krüss
|
||||
*
|
||||
* For the full copyright and license information, please view the LICENSE
|
||||
* file that was distributed with this source code.
|
||||
*/
|
||||
|
||||
namespace Predis\Command\Redis\TDigest;
|
||||
|
||||
use Predis\Command\Command as RedisCommand;
|
||||
|
||||
/**
|
||||
* @see https://redis.io/commands/tdigest.reset/
|
||||
*
|
||||
* Resets a t-digest sketch: empty the sketch and re-initializes it.
|
||||
*/
|
||||
class TDIGESTRESET extends RedisCommand
|
||||
{
|
||||
public function getId()
|
||||
{
|
||||
return 'TDIGEST.RESET';
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,100 @@
|
||||
<?php
|
||||
|
||||
/*
|
||||
* This file is part of the Predis package.
|
||||
*
|
||||
* (c) 2009-2020 Daniele Alessandri
|
||||
* (c) 2021-2023 Till Krüss
|
||||
*
|
||||
* For the full copyright and license information, please view the LICENSE
|
||||
* file that was distributed with this source code.
|
||||
*/
|
||||
|
||||
namespace Predis\Command\Redis\TDigest;
|
||||
|
||||
use Predis\Command\Redis\PredisCommandTestCase;
|
||||
use Predis\Response\ServerException;
|
||||
|
||||
class TDIGESTRESET_Test extends PredisCommandTestCase
|
||||
{
|
||||
/**
|
||||
* {@inheritDoc}
|
||||
*/
|
||||
protected function getExpectedCommand(): string
|
||||
{
|
||||
return TDIGESTRESET::class;
|
||||
}
|
||||
|
||||
/**
|
||||
* {@inheritDoc}
|
||||
*/
|
||||
protected function getExpectedId(): string
|
||||
{
|
||||
return 'TDIGESTRESET';
|
||||
}
|
||||
|
||||
/**
|
||||
* @group disconnected
|
||||
*/
|
||||
public function testFilterArguments(): void
|
||||
{
|
||||
$actualArguments = ['key'];
|
||||
$expectedArguments = ['key'];
|
||||
|
||||
$command = $this->getCommand();
|
||||
$command->setArguments($actualArguments);
|
||||
|
||||
$this->assertSameValues($expectedArguments, $command->getArguments());
|
||||
}
|
||||
|
||||
/**
|
||||
* @group disconnected
|
||||
*/
|
||||
public function testParseResponse(): void
|
||||
{
|
||||
$this->assertSame(1, $this->getCommand()->parseResponse(1));
|
||||
}
|
||||
|
||||
/**
|
||||
* @group connected
|
||||
* @return void
|
||||
* @requiresRedisBfVersion >= 2.4.0
|
||||
*/
|
||||
public function testResetExistingSketch(): void
|
||||
{
|
||||
$redis = $this->getClient();
|
||||
|
||||
$redis->tdigestcreate('key', 500);
|
||||
$redis->tdigestadd('key', 1, 2, 2, 3, 3, 3);
|
||||
|
||||
$this->assertSame(
|
||||
['1', '2', '2', '3', '3', '3'],
|
||||
$redis->tdigestbyrank('key', 0, 1, 2, 3, 4, 5)
|
||||
);
|
||||
|
||||
$actualResponse = $redis->tdigestreset('key');
|
||||
$info = $redis->tdigestinfo('key');
|
||||
|
||||
$this->assertEquals('OK', $actualResponse);
|
||||
$this->assertSame(500, $info['Compression']);
|
||||
$this->assertSame(
|
||||
['nan', 'nan', 'nan', 'nan', 'nan', 'nan'],
|
||||
$redis->tdigestbyrank('key', 0, 1, 2, 3, 4, 5)
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @group connected
|
||||
* @return void
|
||||
* @requiresRedisBfVersion >= 2.4.0
|
||||
*/
|
||||
public function testThrowsExceptionOnNonExistingTDigestSketch(): void
|
||||
{
|
||||
$redis = $this->getClient();
|
||||
|
||||
$this->expectException(ServerException::class);
|
||||
$this->expectExceptionMessage('ERR T-Digest: key does not exist');
|
||||
|
||||
$redis->tdigestreset('key');
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user