Extended RediSearch support by implementing FT.DICTDUMP command (#1157)

* add support for CF.ADDNX

* fix key name

* fix wrong command

* Pulling changes

* Added support for FT.CREATE command

* Fixed tests to choose correct DB

* Added test coverage

* Revert changes for missing commands

* Added data types enums, added methods default assignments

* Fixed vector field, removed default assignments, fixed tests

* Added constants enum for Sortable argument, renamed arguments object

* Codestyle fixes

* Rename test class

* Added support for FT.DICTADD command

* Added support for FT.DICTDUMP command

* Codestyle fixes

---------

Co-authored-by: shacharPash <shachar.pashchur@redis.com>
Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>
This commit is contained in:
Vladyslav Vildanov
2023-02-23 15:00:37 +02:00
committed by GitHub
parent 1684469302
commit 736370c0bc
4 changed files with 116 additions and 0 deletions
+1
View File
@@ -93,6 +93,7 @@ use Predis\Command\Redis\Container\FUNCTIONS;
* @method $this ftcreate(string $index, Schema $schema, ?CreateArguments $arguments = null)
* @method $this ftdictadd(string $dict, ...$term)
* @method $this ftdictdel(string $dict, ...$term)
* @method $this ftdictdump(string $dict)
* @method $this ftinfo(string $index)
* @method $this ftsearch(string $index, string $query, ?SearchArguments $arguments = null)
* @method $this get($key)
+1
View File
@@ -102,6 +102,7 @@ use Predis\Response\Status;
* @method Status ftcreate(string $index, Schema $schema, ?CreateArguments $arguments = null)
* @method int ftdictadd(string $dict, ...$term)
* @method int ftdictdel(string $dict, ...$term)
* @method array ftdictdump(string $dict)
* @method array ftinfo(string $index)
* @method array ftsearch(string $index, string $query, ?SearchArguments $arguments = null)
* @method string|null get(string $key)
+28
View File
@@ -0,0 +1,28 @@
<?php
/*
* This file is part of the Predis package.
*
* (c) 2009-2020 Daniele Alessandri
* (c) 2021-2023 Till Krüss
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Predis\Command\Redis\Search;
use Predis\Command\Command as RedisCommand;
/**
* @see https://redis.io/commands/ft.dictdump/
*
* Dump all terms in the given dictionary.
*/
class FTDICTDUMP extends RedisCommand
{
public function getId()
{
return 'FT.DICTDUMP';
}
}
@@ -0,0 +1,86 @@
<?php
/*
* This file is part of the Predis package.
*
* (c) 2009-2020 Daniele Alessandri
* (c) 2021-2023 Till Krüss
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Predis\Command\Redis\Search;
use Predis\Command\Redis\PredisCommandTestCase;
use Predis\Response\ServerException;
class FTDICTDUMP_Test extends PredisCommandTestCase
{
/**
* {@inheritDoc}
*/
protected function getExpectedCommand(): string
{
return FTDICTDUMP::class;
}
/**
* {@inheritDoc}
*/
protected function getExpectedId(): string
{
return 'FTDICTDUMP';
}
/**
* @group disconnected
*/
public function testFilterArguments(): void
{
$actualArguments = ['dict'];
$expectedArguments = ['dict'];
$command = $this->getCommand();
$command->setArguments($actualArguments);
$this->assertSameValues($expectedArguments, $command->getArguments());
}
/**
* @group disconnected
*/
public function testParseResponse(): void
{
$this->assertSame(1, $this->getCommand()->parseResponse(1));
}
/**
* @group connected
* @return void
* @requiresRediSearchVersion >= 1.4.0
*/
public function testDumpTermsFromGivenDictionary(): void
{
$redis = $this->getClient();
$redis->ftdictadd('dict', 'foo', 'bar');
$this->assertSame(['bar', 'foo'], $redis->ftdictdump('dict'));
}
/**
* @group connected
* @return void
* @requiresRediSearchVersion >= 1.4.0
*/
public function testThrowsExceptionOnNonExistingDictionary(): void
{
$redis = $this->getClient();
$this->expectException(ServerException::class);
$this->expectExceptionMessage('could not open dict key');
$redis->ftdictdump('dict');
}
}