geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-08-30 04:02:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor optimization in the HashRing class when adding/removing nodes from the ring

Browse Source
This commit is contained in:
Daniele Alessandri
2009-11-11 11:57:59 +01:00
parent 25d995942d
commit 7dde9ff93c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Predis.php
+4 -2
View File
@@ -679,8 +679,9 @@ class HashRing {
}
public function add($node) {
$nodeHash = (string) $node;
for ($i = 0; $i < self::NUMBER_OF_REPLICAS; $i++) {
$key = crc32((string)$node . ':' . $i);
$key = crc32($nodeHash . ':' . $i);
$this->_ring[$key] = $node;
}
ksort($this->_ring, SORT_NUMERIC);
@@ -688,8 +689,9 @@ class HashRing {
}
public function remove($node) {
$nodeHash = (string) $node;
for ($i = 0; $i < self::NUMBER_OF_REPLICAS; $i++) {
$key = crc32((string)$node . '_' . $i);
$key = crc32($nodeHash . '_' . $i);
unset($this->_ring[$key]);
$this->_ringKeys = array_filter($this->_ringKeys, function($rk) use($key) {
return $rk !== $key;