geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-08-31 20:53:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added support for LMOVE command (#863)

Browse Source 
Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>
This commit is contained in:
Vladyslav Vildanov
2022-12-12 18:37:28 +02:00
committed by GitHub
parent f9e77a0562
commit 87ecd7bde2
4 changed files with 237 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ClientContextInterface.php
+1
View File
@@ -81,6 +81,7 @@ use Predis\Command\CommandInterface;
* @method $this lindex($key, $index)
* @method $this linsert($key, $whence, $pivot, $value)
* @method $this llen($key)
* @method $this lmove(string $source, string $destination, string $where, string $to)
* @method $this lpop($key)
* @method $this lpush($key, array $values)
* @method $this lpushx($key, array $values)
src/ClientInterface.php
+1
View File
@@ -90,6 +90,7 @@ use Predis\Response\Status;
* @method string|null lindex(string $key, int $index)
* @method int linsert(string $key, $whence, $pivot, $value)
* @method int llen(string $key)
* @method string lmove(string $source, string $destination, string $where, string $to)
* @method string|null lpop(string $key)
* @method int lpush(string $key, array $values)
* @method int lpushx(string $key, array $values)
src/Command/Redis/LMOVE.php
+13
View File
@@ -0,0 +1,13 @@
<?php
namespace Predis\Command\Redis;
use Predis\Command\Command as RedisCommand;
class LMOVE extends RedisCommand
{
public function getId()
{
return 'LMOVE';
}
}
tests/Predis/Command/Redis/LMOVE_Test.php
+222
View File
@@ -0,0 +1,222 @@
<?php
namespace Predis\Command\Redis;
use Predis\Response\ServerException;
/**
* @group commands
* @group realm-list
*/
class LMOVE_Test extends PredisCommandTestCase
{
/**
* @inheritDoc
*/
protected function getExpectedCommand(): string
{
return LMOVE::class;
}
/**
* @inheritDoc
*/
protected function getExpectedId(): string
{
return 'LMOVE';
}
/**
* @group disconnected
*/
public function testFilterArguments(): void
{
$arguments = ['list', 'argument1', 'argument2', 'argument3'];
$expected = ['list', 'argument1', 'argument2', 'argument3'];
$command = $this->getCommand();
$command->setArguments($arguments);
$this->assertSame($expected, $command->getArguments());
}
/**
* @group disconnected
*/
public function testParseResponse(): void
{
$this->assertSame(1, $this->getCommand()->parseResponse(1));
}
/**
* @group connected
* @dataProvider listsProvider
* @param array $firstList
* @param array $secondList
* @param string $where
* @param string $to
* @param string $expectedResponse
* @param array $expectedModifiedFirstList
* @param array $expectedModifiedSecondList
* @return void
* @requiresRedisVersion >= 6.2.0
*/
public function testReturnsCorrectListElement(
array $firstList,
array $secondList,
string $where,
string $to,
string $expectedResponse,
array $expectedModifiedFirstList,
array $expectedModifiedSecondList
): void {
$redis = $this->getClient();
$redis->rpush('test-lmove1', $firstList);
$redis->rpush('test-lmove2', $secondList);
$actualResponse = $redis->lmove('test-lmove1', 'test-lmove2', $where, $to);
$this->assertSame($expectedResponse, $actualResponse);
$this->assertSame($expectedModifiedFirstList, $redis->lrange('test-lmove1', 0, -1));
$this->assertSame($expectedModifiedSecondList, $redis->lrange('test-lmove2', 0, -1));
}
/**
* @group connected
* @return void
* @requiresRedisVersion >= 6.2.0
*/
public function testReturnsNullAndNoOperationPerformedOnNonExistingSource(): void
{
$redis = $this->getClient();
$expectedList = ['element1', 'element2', 'element3'];
$redis->rpush('test-lmove1', $expectedList);
$actualResponse = $redis->lmove('test-lmove2', 'test-lmove1', 'LEFT', 'LEFT');
$this->assertNull($actualResponse);
$this->assertSame($expectedList, $redis->lrange('test-lmove1', 0, -1));
}
/**
* @group connected
* @dataProvider sameListProvider
* @param array $list
* @param string $where
* @param string $to
* @param string $expectedResponse
* @param array $expectedModifiedList
* @return void
* @requiresRedisVersion >= 6.2.0
*/
public function testReturnsCorrectListElementAndListRotationPerformedOnTheSameListOperation(
array $list,
string $where,
string $to,
string $expectedResponse,
array $expectedModifiedList
): void {
$redis = $this->getClient();
$redis->rpush('test-lmove1', $list);
$actualResponse = $redis->lmove('test-lmove1', 'test-lmove1', $where, $to);
$this->assertSame($expectedResponse, $actualResponse);
$this->assertSame($expectedModifiedList, $redis->lrange('test-lmove1', 0, -1));
}
/**
* @group connected
* @return void
* @requiresRedisVersion >= 6.2.0
*/
public function testThrowsExceptionOnWrongType(): void
{
$this->expectException(ServerException::class);
$this->expectExceptionMessage('Operation against a key holding the wrong kind of value');
$redis = $this->getClient();
$redis->set('foo', 'bar');
$redis->lmove('foo', 'test-lmove', 'LEFT', 'LEFT');
}
public function listsProvider(): array
{
return [
'move first element from list into head of another list' => [
['element1', 'element2', 'element3'],
['element4', 'element5', 'element6'],
'LEFT',
'LEFT',
'element1',
['element2', 'element3'],
['element1', 'element4', 'element5', 'element6'],
],
'move first element from list into tail of another list' => [
['element1', 'element2', 'element3'],
['element4', 'element5', 'element6'],
'LEFT',
'RIGHT',
'element1',
['element2', 'element3'],
['element4', 'element5', 'element6', 'element1'],
],
'move last element from list into head of another list' => [
['element1', 'element2', 'element3'],
['element4', 'element5', 'element6'],
'RIGHT',
'LEFT',
'element3',
['element1', 'element2'],
['element3', 'element4', 'element5', 'element6'],
],
'move last element from list into tail of another list' => [
['element1', 'element2', 'element3'],
['element4', 'element5', 'element6'],
'RIGHT',
'RIGHT',
'element3',
['element1', 'element2'],
['element4', 'element5', 'element6', 'element3'],
],
];
}
public function sameListProvider(): array
{
return [
'list rotation - head into tail' => [
['element1', 'element2', 'element3'],
'LEFT',
'RIGHT',
'element1',
['element2', 'element3', 'element1'],
],
'list rotation - tail into head' => [
['element1', 'element2', 'element3'],
'RIGHT',
'LEFT',
'element3',
['element3', 'element1', 'element2'],
],
'list rotation - head into head' => [
['element1', 'element2', 'element3'],
'LEFT',
'LEFT',
'element1',
['element1', 'element2', 'element3'],
],
'list rotation - tail into tail' => [
['element1', 'element2', 'element3'],
'RIGHT',
'RIGHT',
'element3',
['element1', 'element2', 'element3'],
],
];
}
}