mirror of
https://github.com/predis/predis.git
synced 2026-09-04 23:08:00 +00:00
Remove useless method.
It is better to wrap explicitly a multibulk response iterator into a multibulk tuple response iterator instead of hard-coding that into a specialized method.
This commit is contained in:
@@ -74,14 +74,4 @@ class MultiBulk extends MultiBulkIterator
|
||||
{
|
||||
return $this->connection->read();
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns an iterator that reads a multi-bulk response as a list of tuples.
|
||||
*
|
||||
* @return MultiBulkTuple
|
||||
*/
|
||||
public function asTuple()
|
||||
{
|
||||
return new MultiBulkTuple($this);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -49,18 +49,6 @@ class MultiBulkTest extends PredisTestCase
|
||||
$this->assertEquals('PONG', $client->ping());
|
||||
}
|
||||
|
||||
/**
|
||||
* @group connected
|
||||
*/
|
||||
public function testIterableMultibulkCanBeWrappedAsTupleIterator()
|
||||
{
|
||||
$client = $this->getClient();
|
||||
$client->mset('foo', 'bar', 'hoge', 'piyo');
|
||||
|
||||
$this->assertInstanceOf('Predis\Response\Iterator\MultiBulk', $iterator = $client->mget('foo', 'bar'));
|
||||
$this->assertInstanceOf('Predis\Response\Iterator\MultiBulkTuple', $iterator->asTuple());
|
||||
}
|
||||
|
||||
/**
|
||||
* @group connected
|
||||
*/
|
||||
|
||||
@@ -56,7 +56,9 @@ class MultiBulkTupleTest extends PredisTestCase
|
||||
$client = $this->getClient();
|
||||
$client->zadd('metavars', 1, 'foo', 2, 'hoge', 3, 'lol');
|
||||
|
||||
$this->assertInstanceOf('OuterIterator', $iterator = $client->zrange('metavars', 0, -1, 'withscores')->asTuple());
|
||||
$iterator = new MultiBulkTuple($client->zrange('metavars', 0, -1, 'withscores'));
|
||||
|
||||
$this->assertInstanceOf('OuterIterator', $iterator);
|
||||
$this->assertInstanceOf('Predis\Response\Iterator\MultiBulkTuple', $iterator);
|
||||
$this->assertInstanceOf('Predis\Response\Iterator\MultiBulk', $iterator->getInnerIterator());
|
||||
$this->assertTrue($iterator->valid());
|
||||
@@ -85,7 +87,7 @@ class MultiBulkTupleTest extends PredisTestCase
|
||||
$client = $this->getClient();
|
||||
$client->zadd('metavars', 1, 'foo', 2, 'hoge', 3, 'lol');
|
||||
|
||||
$iterator = $client->zrange('metavars', 0, -1, 'withscores')->asTuple();
|
||||
$iterator = new MultiBulkTuple($client->zrange('metavars', 0, -1, 'withscores'));
|
||||
|
||||
unset($iterator);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user