Added RESP3 protocol option, establish RESP3 connection (#1267)

* Added RESP3 protocol option, establish RESP3 connection

* Removed method from the interface

src/Connection/AbstractConnection.php

@@ -101,6 +101,14 @@ abstract class AbstractConnection implements NodeConnectionInterface
         $this->initCommands[] = $command;
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function getInitCommands(): array
+    {
+        return $this->initCommands;
+    }
+
     /**
      * {@inheritdoc}
      */

src/Connection/Factory.php

@@ -174,6 +174,12 @@ class Factory implements FactoryInterface
             );
         }
 
+        if (isset($parameters->protocol) && (int) $parameters->protocol > 2) {
+            $connection->addConnectCommand(
+                new RawCommand('HELLO', [$parameters->protocol, 'SETNAME', 'predis'])
+            );
+        }
+
         if (isset($parameters->database) && strlen($parameters->database)) {
             $connection->addConnectCommand(
                 new RawCommand('SELECT', [$parameters->database])

src/Connection/Parameters.php

@@ -25,6 +25,7 @@ class Parameters implements ParametersInterface
         'scheme' => 'tcp',
         'host' => '127.0.0.1',
         'port' => 6379,
+        'protocol' => 2,
     ];
 
     /**

src/Connection/ParametersInterface.php

@@ -22,6 +22,7 @@ namespace Predis\Connection;
  * @property string $scheme             Connection scheme, such as 'tcp' or 'unix'.
  * @property string $host               IP address or hostname of Redis.
  * @property int    $port               TCP port on which Redis is listening to.
+ * @property int    $protocol           Version of RESP protocol.
  * @property string $path               Path of a UNIX domain socket file.
  * @property string $alias              Alias for the connection.
  * @property float  $timeout            Timeout for the connect() operation.

tests/Predis/Connection/FactoryTest.php

@@ -12,6 +12,7 @@
 
 namespace Predis\Connection;
 
+use Predis\Command\RawCommand;
 use PredisTestCase;
 use ReflectionObject;
 use stdClass;
@@ -538,6 +539,22 @@ class FactoryTest extends PredisTestCase
         $factory->create('test://127.0.0.1');
     }
 
+    /**
+     * @group disconnected
+     * @return void
+     */
+    public function testCreatesResp3ConnectionOnProtocolParameterGiven(): void
+    {
+        $parameters = ['protocol' => 3];
+
+        $factory = new Factory();
+        $connection = $factory->create($parameters);
+        $initCommands = $connection->getInitCommands();
+
+        $this->assertInstanceOf(RawCommand::class, $initCommands[0]);
+        $this->assertSame('HELLO', $initCommands[0]->getId());
+    }
+
     // ******************************************************************** //
     // ---- HELPER METHODS ------------------------------------------------ //
     // ******************************************************************** //

tests/Predis/Connection/ParametersTest.php

@@ -401,6 +401,7 @@ class ParametersTest extends PredisTestCase
             'scheme' => 'tcp',
             'host' => '127.0.0.1',
             'port' => 6379,
+            'protocol' => 2,
         ];
     }
 

tests/Predis/Connection/StreamConnectionTest.php

@@ -195,4 +195,21 @@ class StreamConnectionTest extends PredisConnectionTestCase
         $this->assertArrayHasKey('tcp_nodelay', $options['socket']);
         $this->assertFalse($options['socket']['tcp_nodelay']);
     }
+
+    /**
+     * @group disconnected
+     * @return void
+     */
+    public function testGetInitCommandsReturnsGivenInitCommands(): void
+    {
+        $command = new RawCommand('HELLO', [3]);
+
+        $connection = $this->createConnection();
+        $connection->addConnectCommand($command);
+
+        $initCommands = $connection->getInitCommands();
+
+        $this->assertInstanceOf(RawCommand::class, $initCommands[0]);
+        $this->assertSame('HELLO', $initCommands[0]->getId());
+    }
 }