geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-08-30 20:21:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cache value casters in static member variable.

Browse Source 
This optimization is mostly useful since connection parameters can be
instantiated more than one time in a script when using clustering or
replication.
This commit is contained in:
Daniele Alessandri
2013-12-02 14:34:02 +01:00
parent 5b7504b069
commit d27d3b0acb
1 changed files with 42 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Predis/Connection/ConnectionParameters.php
+42 -40
View File
@@ -29,6 +29,14 @@ class ConnectionParameters implements ConnectionParametersInterface
'timeout' => 5.0,
);
private static $casters = array(
'port' => 'self::castInteger',
'async_connect' => 'self::castBoolean',
'persistent' => 'self::castBoolean',
'timeout' => 'self::castFloat',
'read_write_timeout' => 'self::castFloat',
);
/**
* @param string|array Connection parameters in the form of an URI string or a named array.
*/
@@ -58,46 +66,7 @@ class ConnectionParameters implements ConnectionParametersInterface
*/
protected function getValueCasters()
{
return array(
'port' => 'self::castInteger',
'async_connect' => 'self::castBoolean',
'persistent' => 'self::castBoolean',
'timeout' => 'self::castFloat',
'read_write_timeout' => 'self::castFloat',
);
}
/**
* Validates value as boolean.
*
* @param mixed $value Input value.
* @return boolean
*/
private static function castBoolean($value)
{
return (bool) $value;
}
/**
* Validates value as float.
*
* @param mixed $value Input value.
* @return float
*/
private static function castFloat($value)
{
return (float) $value;
}
/**
* Validates value as integer.
*
* @param mixed $value Input value.
* @return int
*/
private static function castInteger($value)
{
return (int) $value;
return self::$casters;
}
/**
@@ -150,6 +119,39 @@ class ConnectionParameters implements ConnectionParametersInterface
return $parameters;
}
/**
* Validates value as boolean.
*
* @param mixed $value Input value.
* @return boolean
*/
private static function castBoolean($value)
{
return (bool) $value;
}
/**
* Validates value as float.
*
* @param mixed $value Input value.
* @return float
*/
private static function castFloat($value)
{
return (float) $value;
}
/**
* Validates value as integer.
*
* @param mixed $value Input value.
* @return int
*/
private static function castInteger($value)
{
return (int) $value;
}
/**
* {@inheritdoc}
*/