geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-09-19 06:47:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] Drop TODO and implement type check in utility method.

Browse Source 
From feedback to PR #644.
This commit is contained in:
Daniele Alessandri
2020-08-21 11:16:25 +02:00
parent a772f0b16b
commit d4bcf912f4
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PHPUnit/PredisTestCase.php
+8 -2
View File
@@ -204,9 +204,15 @@ abstract class PredisTestCase extends \PHPUnit\Framework\TestCase
*/
protected function getMockConnectionOfType($interface, $parameters = null)
{
$connection = $this->getMockBuilder($interface)->getMock();
if (!is_a($interface, '\Predis\Connection\NodeConnectionInterface', true)) {
$method = __METHOD__;
// TODO: verify that $connection is an instance of \Predis\Connection\NodeConnectionInterface
throw new \InvalidArgumentException(
"Argument `\$interface` for $method() expects a type implementing Predis\Connection\NodeConnectionInterface"
);
}
$connection = $this->getMockBuilder($interface)->getMock();
if ($parameters) {
$parameters = Connection\Parameters::create($parameters);