Extended Count-Min Sketch support by implementing CMS.INITBYPROB command (#1090)

* Added support for CMS.INITBYPROB command

* Codestyle fixes

---------

Co-authored-by: Vladyslav Vildanov <vladyslavvildanov@Vladyslav-Vildanov-MacBook-Pro.local>
This commit is contained in:
Vladyslav Vildanov
2023-02-02 14:50:39 +02:00
committed by GitHub
parent 5304ad95e8
commit e831c71cc6
4 changed files with 119 additions and 0 deletions
+1
View File
@@ -73,6 +73,7 @@ use Predis\Command\CommandInterface;
* @method $this cfscandump(string $key, int $iterator)
* @method $this cmsinfo(string $key)
* @method $this cmsinitbydim(string $key, int $width, int $depth)
* @method $this cmsinitbyprob(string $key, float $errorRate, float $probability)
* @method $this decr($key)
* @method $this decrby($key, $decrement)
* @method $this failover(?To $to = null, bool $abort = false, int $timeout = -1)
+1
View File
@@ -82,6 +82,7 @@ use Predis\Response\Status;
* @method array cfscandump(string $key, int $iterator)
* @method array cmsinfo(string $key)
* @method Status cmsinitbydim(string $key, int $width, int $depth)
* @method Status cmsinitbyprob(string $key, float $errorRate, float $probability)
* @method int decr(string $key)
* @method int decrby(string $key, int $decrement)
* @method Status failover(?To $to = null, bool $abort = false, int $timeout = -1)
@@ -0,0 +1,28 @@
<?php
/*
* This file is part of the Predis package.
*
* (c) 2009-2020 Daniele Alessandri
* (c) 2021-2023 Till Krüss
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Predis\Command\Redis\CountMinSketch;
use Predis\Command\Command as RedisCommand;
/**
* @see https://redis.io/commands/cms.initbyprob/
*
* Initializes a Count-Min Sketch to accommodate requested tolerances.
*/
class CMSINITBYPROB extends RedisCommand
{
public function getId()
{
return 'CMS.INITBYPROB';
}
}
@@ -0,0 +1,89 @@
<?php
/*
* This file is part of the Predis package.
*
* (c) 2009-2020 Daniele Alessandri
* (c) 2021-2023 Till Krüss
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Predis\Command\Redis\CountMinSketch;
use Predis\Command\Redis\PredisCommandTestCase;
use Predis\Response\ServerException;
class CMSINITBYPROB_Test extends PredisCommandTestCase
{
/**
* {@inheritDoc}
*/
protected function getExpectedCommand(): string
{
return CMSINITBYPROB::class;
}
/**
* {@inheritDoc}
*/
protected function getExpectedId(): string
{
return 'CMSINITBYPROB';
}
/**
* @group disconnected
*/
public function testFilterArguments(): void
{
$actualArguments = ['key', 0.001, 0.01];
$expectedArguments = ['key', 0.001, 0.01];
$command = $this->getCommand();
$command->setArguments($actualArguments);
$this->assertSameValues($expectedArguments, $command->getArguments());
}
/**
* @group disconnected
*/
public function testParseResponse(): void
{
$this->assertSame(1, $this->getCommand()->parseResponse(1));
}
/**
* @group connected
* @return void
* @requiresRedisBfVersion >= 2.0.0
*/
public function testInitializeCountMinSketchWithDesiredErrorRateAndProbability(): void
{
$redis = $this->getClient();
$actualResponse = $redis->cmsinitbyprob('key', 0.001, 0.01);
$info = $redis->cmsinfo('key');
$this->assertEquals('OK', $actualResponse);
$this->assertSame(2000, $info['width']);
$this->assertSame(7, $info['depth']);
}
/**
* @group connected
* @requiresRedisBfVersion >= 2.0.0
*/
public function testThrowsExceptionOnAlreadyExistingKey(): void
{
$this->expectException(ServerException::class);
$this->expectExceptionMessage('CMS: key already exists');
$redis = $this->getClient();
$redis->set('cmsinitbydim_foo', 'bar');
$redis->cmsinitbyprob('cmsinitbydim_foo', 0.001, 0.01);
}
}