explicitly mark nullable parameters as nullable (#1448)

* explicitly mark nullable parameters as nullable
* add job to run tests with PHP 8.4
This commit is contained in:
Christian Flothmann
2024-04-30 21:14:13 +02:00
committed by GitHub
parent ed90750c1f
commit e83b393e09
28 changed files with 89 additions and 88 deletions
+2 -1
View File
@@ -28,6 +28,7 @@ jobs:
- '8.1'
- '8.2'
- '8.3'
- '8.4'
redis:
- 3
- 4
@@ -69,7 +70,7 @@ jobs:
run: vendor/bin/phpunit --coverage-clover build/logs/clover-default.xml --coverage-filter ./src
- name: Run tests using Relay
if: ${{ matrix.redis >= '6' }}
if: ${{ matrix.php != '8.4' && matrix.redis >= '6' }}
run: vendor/bin/phpunit -c phpunit.relay.xml
- name: Run tests using Relay with coverage
+7 -7
View File
@@ -472,7 +472,7 @@ class Client implements ClientInterface, IteratorAggregate
*
* @return Pipeline|array
*/
protected function createPipeline(array $options = null, $callable = null)
protected function createPipeline(?array $options = null, $callable = null)
{
if (isset($options['atomic']) && $options['atomic']) {
$class = Atomic::class;
@@ -520,12 +520,12 @@ class Client implements ClientInterface, IteratorAggregate
/**
* Actual transaction context initializer method.
*
* @param array $options Options for the context.
* @param mixed $callable Optional callable used to execute the context.
* @param array|null $options Options for the context.
* @param mixed $callable Optional callable used to execute the context.
*
* @return MultiExecTransaction|array
*/
protected function createTransaction(array $options = null, $callable = null)
protected function createTransaction(?array $options = null, $callable = null)
{
$transaction = new MultiExecTransaction($this, $options);
@@ -552,12 +552,12 @@ class Client implements ClientInterface, IteratorAggregate
/**
* Actual publish/subscribe context initializer method.
*
* @param array $options Options for the context.
* @param mixed $callable Optional callable used to execute the context.
* @param array|null $options Options for the context.
* @param mixed $callable Optional callable used to execute the context.
*
* @return PubSubConsumer|null
*/
protected function createPubSub(array $options = null, $callable = null)
protected function createPubSub(?array $options = null, $callable = null)
{
if ($this->connection instanceof RelayConnection) {
$pubsub = new RelayPubSubConsumer($this, $options);
+15 -15
View File
@@ -65,8 +65,8 @@ use Predis\Command\Redis\Container\Search\FTCURSOR;
* @method $this randomkey()
* @method $this rename($key, $target)
* @method $this renamenx($key, $target)
* @method $this scan($cursor, array $options = null)
* @method $this sort($key, array $options = null)
* @method $this scan($cursor, ?array $options = null)
* @method $this sort($key, ?array $options = null)
* @method $this sort_ro(string $key, ?string $byPattern = null, ?LimitOffsetCount $limit = null, array $getPatterns = [], ?string $sorting = null, bool $alpha = false)
* @method $this ttl($key)
* @method $this type($key)
@@ -163,7 +163,7 @@ use Predis\Command\Redis\Container\Search\FTCURSOR;
* @method $this hmget($key, array $fields)
* @method $this hmset($key, array $dictionary)
* @method $this hrandfield(string $key, int $count = 1, bool $withValues = false)
* @method $this hscan($key, $cursor, array $options = null)
* @method $this hscan($key, $cursor, ?array $options = null)
* @method $this hset($key, $field, $value)
* @method $this hsetnx($key, $field, $value)
* @method $this hvals($key)
@@ -225,7 +225,7 @@ use Predis\Command\Redis\Container\Search\FTCURSOR;
* @method $this spop($key, $count = null)
* @method $this srandmember($key, $count = null)
* @method $this srem($key, $member)
* @method $this sscan($key, $cursor, array $options = null)
* @method $this sscan($key, $cursor, ?array $options = null)
* @method $this sunion(array|string $keys)
* @method $this sunionstore($destination, array|string $keys)
* @method $this tdigestadd(string $key, float ...$value)
@@ -255,7 +255,7 @@ use Predis\Command\Redis\Container\Search\FTCURSOR;
* @method $this tsdecrby(string $key, float $value, ?DecrByArguments $arguments = null)
* @method $this tsdel(string $key, int $fromTimestamp, int $toTimestamp)
* @method $this tsdeleterule(string $sourceKey, string $destKey)
* @method $this tsget(string $key, GetArguments $arguments = null)
* @method $this tsget(string $key, ?GetArguments $arguments = null)
* @method $this tsincrby(string $key, float $value, ?IncrByArguments $arguments = null)
* @method $this tsinfo(string $key, ?InfoArguments $arguments = null)
* @method $this tsmadd(mixed ...$keyTimestampValue)
@@ -277,22 +277,22 @@ use Predis\Command\Redis\Container\Search\FTCURSOR;
* @method $this zmpop(array $keys, string $modifier = 'min', int $count = 1)
* @method $this zmscore(string $key, string ...$member)
* @method $this zrandmember(string $key, int $count = 1, bool $withScores = false)
* @method $this zrange($key, $start, $stop, array $options = null)
* @method $this zrangebyscore($key, $min, $max, array $options = null)
* @method $this zrange($key, $start, $stop, ?array $options = null)
* @method $this zrangebyscore($key, $min, $max, ?array $options = null)
* @method $this zrangestore(string $destination, string $source, int|string $min, string|int $max, string|bool $by = false, bool $reversed = false, bool $limit = false, int $offset = 0, int $count = 0)
* @method $this zrank($key, $member)
* @method $this zrem($key, $member)
* @method $this zremrangebyrank($key, $start, $stop)
* @method $this zremrangebyscore($key, $min, $max)
* @method $this zrevrange($key, $start, $stop, array $options = null)
* @method $this zrevrangebyscore($key, $max, $min, array $options = null)
* @method $this zrevrange($key, $start, $stop, ?array $options = null)
* @method $this zrevrangebyscore($key, $max, $min, ?array $options = null)
* @method $this zrevrank($key, $member)
* @method $this zunion(array $keys, int[] $weights = [], string $aggregate = 'sum', bool $withScores = false)
* @method $this zunionstore(string $destination, array $keys, int[] $weights = [], string $aggregate = 'sum')
* @method $this zscore($key, $member)
* @method $this zscan($key, $cursor, array $options = null)
* @method $this zrangebylex($key, $start, $stop, array $options = null)
* @method $this zrevrangebylex($key, $start, $stop, array $options = null)
* @method $this zscan($key, $cursor, ?array $options = null)
* @method $this zrangebylex($key, $start, $stop, ?array $options = null)
* @method $this zrevrangebylex($key, $start, $stop, ?array $options = null)
* @method $this zremrangebylex($key, $min, $max)
* @method $this zlexcount($key, $min, $max)
* @method $this pexpiretime(string $key)
@@ -312,7 +312,7 @@ use Predis\Command\Redis\Container\Search\FTCURSOR;
* @method $this evalsha($script, $numkeys, $keyOrArg1 = null, $keyOrArgN = null)
* @method $this evalsha_ro(string $sha1, array $keys, ...$argument)
* @method $this script($subcommand, $argument = null)
* @method $this shutdown(bool $noSave = null, bool $now = false, bool $force = false, bool $abort = false)
* @method $this shutdown(?bool $noSave = null, bool $now = false, bool $force = false, bool $abort = false)
* @method $this auth($password)
* @method $this echo($message)
* @method $this ping($message = null)
@@ -335,8 +335,8 @@ use Predis\Command\Redis\Container\Search\FTCURSOR;
* @method $this geohash($key, array $members)
* @method $this geopos($key, array $members)
* @method $this geodist($key, $member1, $member2, $unit = null)
* @method $this georadius($key, $longitude, $latitude, $radius, $unit, array $options = null)
* @method $this georadiusbymember($key, $member, $radius, $unit, array $options = null)
* @method $this georadius($key, $longitude, $latitude, $radius, $unit, ?array $options = null)
* @method $this georadiusbymember($key, $member, $radius, $unit, ?array $options = null)
* @method $this geosearch(string $key, FromInterface $from, ByInterface $by, ?string $sorting = null, int $count = -1, bool $any = false, bool $withCoord = false, bool $withDist = false, bool $withHash = false)
* @method $this geosearchstore(string $destination, string $source, FromInterface $from, ByInterface $by, ?string $sorting = null, int $count = -1, bool $any = false, bool $storeDist = false)
*
+20 -20
View File
@@ -74,8 +74,8 @@ use Predis\Response\Status;
* @method string|null randomkey()
* @method mixed rename(string $key, string $target)
* @method int renamenx(string $key, string $target)
* @method array scan($cursor, array $options = null)
* @method array sort(string $key, array $options = null)
* @method array scan($cursor, ?array $options = null)
* @method array sort(string $key, ?array $options = null)
* @method array sort_ro(string $key, ?string $byPattern = null, ?LimitOffsetCount $limit = null, array $getPatterns = [], ?string $sorting = null, bool $alpha = false)
* @method int ttl(string $key)
* @method mixed type(string $key)
@@ -172,7 +172,7 @@ use Predis\Response\Status;
* @method array hmget(string $key, array $fields)
* @method mixed hmset(string $key, array $dictionary)
* @method array hrandfield(string $key, int $count = 1, bool $withValues = false)
* @method array hscan(string $key, $cursor, array $options = null)
* @method array hscan(string $key, $cursor, ?array $options = null)
* @method int hset(string $key, string $field, string $value)
* @method int hsetnx(string $key, string $field, string $value)
* @method array hvals(string $key)
@@ -231,10 +231,10 @@ use Predis\Response\Status;
* @method string[] smembers(string $key)
* @method array smismember(string $key, string ...$members)
* @method int smove(string $source, string $destination, string $member)
* @method string|array|null spop(string $key, int $count = null)
* @method string|null srandmember(string $key, int $count = null)
* @method string|array|null spop(string $key, ?int $count = null)
* @method string|null srandmember(string $key, ?int $count = null)
* @method int srem(string $key, array|string $member)
* @method array sscan(string $key, int $cursor, array $options = null)
* @method array sscan(string $key, int $cursor, ?array $options = null)
* @method string[] sunion(array|string $keys)
* @method int sunionstore(string $destination, array|string $keys)
* @method int touch(string[]|string $keyOrKeys, string ...$keys = null)
@@ -265,7 +265,7 @@ use Predis\Response\Status;
* @method int tsdecrby(string $key, float $value, ?DecrByArguments $arguments = null)
* @method int tsdel(string $key, int $fromTimestamp, int $toTimestamp)
* @method Status tsdeleterule(string $sourceKey, string $destKey)
* @method array tsget(string $key, GetArguments $arguments = null)
* @method array tsget(string $key, ?GetArguments $arguments = null)
* @method int tsincrby(string $key, float $value, ?IncrByArguments $arguments = null)
* @method array tsinfo(string $key, ?InfoArguments $arguments = null)
* @method array tsmadd(mixed ...$keyTimestampValue)
@@ -275,12 +275,12 @@ use Predis\Response\Status;
* @method array tsqueryindex(string ...$filterExpression)
* @method array tsrange(string $key, $fromTimestamp, $toTimestamp, ?RangeArguments $arguments = null)
* @method array tsrevrange(string $key, $fromTimestamp, $toTimestamp, ?RangeArguments $arguments = null)
* @method string xadd(string $key, array $dictionary, string $id = '*', array $options = null)
* @method string xadd(string $key, array $dictionary, string $id = '*', ?array $options = null)
* @method int xdel(string $key, string ...$id)
* @method int xlen(string $key)
* @method array xrevrange(string $key, string $end, string $start, ?int $count = null)
* @method array xrange(string $key, string $start, string $end, ?int $count = null)
* @method string xtrim(string $key, array|string $strategy, string $threshold, array $options = null)
* @method string xtrim(string $key, array|string $strategy, string $threshold, ?array $options = null)
* @method int zadd(string $key, array $membersAndScoresDictionary)
* @method int zcard(string $key)
* @method string zcount(string $key, int|string $min, int|string $max)
@@ -295,22 +295,22 @@ use Predis\Response\Status;
* @method array zpopmin(string $key, int $count = 1)
* @method array zpopmax(string $key, int $count = 1)
* @method mixed zrandmember(string $key, int $count = 1, bool $withScores = false)
* @method array zrange(string $key, int|string $start, int|string $stop, array $options = null)
* @method array zrangebyscore(string $key, int|string $min, int|string $max, array $options = null)
* @method array zrange(string $key, int|string $start, int|string $stop, ?array $options = null)
* @method array zrangebyscore(string $key, int|string $min, int|string $max, ?array $options = null)
* @method int zrangestore(string $destination, string $source, int|string $min, int|string $max, string|bool $by = false, bool $reversed = false, bool $limit = false, int $offset = 0, int $count = 0)
* @method int|null zrank(string $key, string $member)
* @method int zrem(string $key, string ...$member)
* @method int zremrangebyrank(string $key, int|string $start, int|string $stop)
* @method int zremrangebyscore(string $key, int|string $min, int|string $max)
* @method array zrevrange(string $key, int|string $start, int|string $stop, array $options = null)
* @method array zrevrangebyscore(string $key, int|string $max, int|string $min, array $options = null)
* @method array zrevrange(string $key, int|string $start, int|string $stop, ?array $options = null)
* @method array zrevrangebyscore(string $key, int|string $max, int|string $min, ?array $options = null)
* @method int|null zrevrank(string $key, string $member)
* @method array zunion(array $keys, int[] $weights = [], string $aggregate = 'sum', bool $withScores = false)
* @method int zunionstore(string $destination, array $keys, int[] $weights = [], string $aggregate = 'sum')
* @method string|null zscore(string $key, string $member)
* @method array zscan(string $key, int $cursor, array $options = null)
* @method array zrangebylex(string $key, string $start, string $stop, array $options = null)
* @method array zrevrangebylex(string $key, string $start, string $stop, array $options = null)
* @method array zscan(string $key, int $cursor, ?array $options = null)
* @method array zrangebylex(string $key, string $start, string $stop, ?array $options = null)
* @method array zrevrangebylex(string $key, string $start, string $stop, ?array $options = null)
* @method int zremrangebylex(string $key, string $min, string $max)
* @method int zlexcount(string $key, string $min, string $max)
* @method int pexpiretime(string $key)
@@ -330,10 +330,10 @@ use Predis\Response\Status;
* @method mixed evalsha(string $script, int $numkeys, string ...$keyOrArg = null)
* @method mixed evalsha_ro(string $sha1, array $keys, ...$argument)
* @method mixed script($subcommand, $argument = null)
* @method Status shutdown(bool $noSave = null, bool $now = false, bool $force = false, bool $abort = false)
* @method Status shutdown(?bool $noSave = null, bool $now = false, bool $force = false, bool $abort = false)
* @method mixed auth(string $password)
* @method string echo(string $message)
* @method mixed ping(string $message = null)
* @method mixed ping(?string $message = null)
* @method mixed select(int $database)
* @method mixed bgrewriteaof()
* @method mixed bgsave()
@@ -353,8 +353,8 @@ use Predis\Response\Status;
* @method array geohash(string $key, array $members)
* @method array geopos(string $key, array $members)
* @method string|null geodist(string $key, $member1, $member2, $unit = null)
* @method array georadius(string $key, $longitude, $latitude, $radius, $unit, array $options = null)
* @method array georadiusbymember(string $key, $member, $radius, $unit, array $options = null)
* @method array georadius(string $key, $longitude, $latitude, $radius, $unit, ?array $options = null)
* @method array georadiusbymember(string $key, $member, $radius, $unit, ?array $options = null)
* @method array geosearch(string $key, FromInterface $from, ByInterface $by, ?string $sorting = null, int $count = -1, bool $any = false, bool $withCoord = false, bool $withDist = false, bool $withHash = false)
* @method int geosearchstore(string $destination, string $source, FromInterface $from, ByInterface $by, ?string $sorting = null, int $count = -1, bool $any = false, bool $storeDist = false)
*
+2 -2
View File
@@ -23,9 +23,9 @@ class PredisStrategy extends ClusterStrategy
protected $distributor;
/**
* @param DistributorInterface $distributor Optional distributor instance.
* @param DistributorInterface|null $distributor Optional distributor instance.
*/
public function __construct(DistributorInterface $distributor = null)
public function __construct(?DistributorInterface $distributor = null)
{
parent::__construct();
+2 -2
View File
@@ -25,9 +25,9 @@ class RedisStrategy extends ClusterStrategy
protected $hashGenerator;
/**
* @param HashGeneratorInterface $hashGenerator Hash generator instance.
* @param HashGeneratorInterface|null $hashGenerator Hash generator instance.
*/
public function __construct(HashGeneratorInterface $hashGenerator = null)
public function __construct(?HashGeneratorInterface $hashGenerator = null)
{
parent::__construct();
@@ -19,9 +19,9 @@ use Predis\Response\Status;
* @method string dump()
* @method Status flush(?string $mode = null)
* @method Status kill()
* @method array list(string $libraryNamePattern = null, bool $withCode = false)
* @method array list(?string $libraryNamePattern = null, bool $withCode = false)
* @method string load(string $functionCode, bool $replace = 'false')
* @method Status restore(string $value, string $policy = null)
* @method Status restore(string $value, ?string $policy = null)
* @method array stats()
*/
class FunctionContainer extends AbstractContainer
@@ -23,7 +23,7 @@ class SubcommandStrategyResolver implements StrategyResolverInterface
*/
private $separator;
public function __construct(string $separator = null)
public function __construct(?string $separator = null)
{
$this->separator = $separator;
}
+1 -1
View File
@@ -32,7 +32,7 @@ abstract class CommunicationException extends PredisException
NodeConnectionInterface $connection,
$message = '',
$code = 0,
Exception $innerException = null
?Exception $innerException = null
) {
parent::__construct(
is_null($message) ? '' : $message,
+2 -2
View File
@@ -41,9 +41,9 @@ class Options implements OptionsInterface
protected $input;
/**
* @param array $options Named array of client options
* @param array|null $options Named array of client options
*/
public function __construct(array $options = null)
public function __construct(?array $options = null)
{
$this->input = $options ?? [];
}
+2 -2
View File
@@ -50,9 +50,9 @@ class PredisCluster implements ClusterInterface, IteratorAggregate, Countable
private $distributor;
/**
* @param StrategyInterface $strategy Optional cluster strategy.
* @param StrategyInterface|null $strategy Optional cluster strategy.
*/
public function __construct(StrategyInterface $strategy = null)
public function __construct(?StrategyInterface $strategy = null)
{
$this->strategy = $strategy ?: new PredisStrategy();
$this->distributor = $this->strategy->getDistributor();
+5 -5
View File
@@ -65,12 +65,12 @@ class RedisCluster implements ClusterInterface, IteratorAggregate, Countable
private $retryInterval = 10;
/**
* @param FactoryInterface $connections Optional connection factory.
* @param StrategyInterface $strategy Optional cluster strategy.
* @param FactoryInterface $connections Optional connection factory.
* @param StrategyInterface|null $strategy Optional cluster strategy.
*/
public function __construct(
FactoryInterface $connections,
StrategyInterface $strategy = null
?StrategyInterface $strategy = null
) {
$this->connections = $connections;
$this->strategy = $strategy ?: new RedisClusterStrategy();
@@ -271,9 +271,9 @@ class RedisCluster implements ClusterInterface, IteratorAggregate, Countable
* the CLUSTER SLOTS command against the specified node or a random one from
* the pool.
*
* @param NodeConnectionInterface $connection Optional connection instance.
* @param NodeConnectionInterface|null $connection Optional connection instance.
*/
public function askSlotMap(NodeConnectionInterface $connection = null)
public function askSlotMap(?NodeConnectionInterface $connection = null)
{
if (!$connection && !$connection = $this->getRandomConnection()) {
return;
+3 -3
View File
@@ -26,12 +26,12 @@ class CompositeStreamConnection extends StreamConnection implements CompositeCon
protected $protocol;
/**
* @param ParametersInterface $parameters Initialization parameters for the connection.
* @param ProtocolProcessorInterface $protocol Protocol processor.
* @param ParametersInterface $parameters Initialization parameters for the connection.
* @param ProtocolProcessorInterface|null $protocol Protocol processor.
*/
public function __construct(
ParametersInterface $parameters,
ProtocolProcessorInterface $protocol = null
?ProtocolProcessorInterface $protocol = null
) {
$this->parameters = $this->assertParameters($parameters);
$this->protocol = $protocol ?: new TextProtocolProcessor();
+4 -4
View File
@@ -28,11 +28,11 @@ trait RelayMethods
/**
* Registers a new `invalidated` event listener.
*
* @param callable $callback
* @param string $pattern
* @param callable $callback
* @param string|null $pattern
* @return bool
*/
public function onInvalidated(?callable $callback, string $pattern = null)
public function onInvalidated(?callable $callback, ?string $pattern = null)
{
return $this->client->onInvalidated($callback, $pattern);
}
@@ -129,7 +129,7 @@ trait RelayMethods
* @param ?int $db
* @return bool
*/
public function flushMemory(string $endpointId = null, int $db = null)
public function flushMemory(?string $endpointId = null, ?int $db = null)
{
return $this->client->flushMemory($endpointId, $db);
}
@@ -72,7 +72,7 @@ class MasterSlaveReplication implements ReplicationInterface
/**
* {@inheritdoc}
*/
public function __construct(ReplicationStrategy $strategy = null)
public function __construct(?ReplicationStrategy $strategy = null)
{
$this->strategy = $strategy ?: new ReplicationStrategy();
}
@@ -117,13 +117,13 @@ class SentinelReplication implements ReplicationInterface
* @param string $service Name of the service for autodiscovery.
* @param array $sentinels Sentinel servers connection parameters.
* @param ConnectionFactoryInterface $connectionFactory Connection factory instance.
* @param ReplicationStrategy $strategy Replication strategy instance.
* @param ReplicationStrategy|null $strategy Replication strategy instance.
*/
public function __construct(
$service,
array $sentinels,
ConnectionFactoryInterface $connectionFactory,
ReplicationStrategy $strategy = null
?ReplicationStrategy $strategy = null
) {
$this->sentinels = $sentinels;
$this->service = $service;
@@ -37,12 +37,12 @@ class CompositeProtocolProcessor implements ProtocolProcessorInterface
protected $reader;
/**
* @param RequestSerializerInterface $serializer Request serializer.
* @param ResponseReaderInterface $reader Response reader.
* @param RequestSerializerInterface|null $serializer Request serializer.
* @param ResponseReaderInterface|null $reader Response reader.
*/
public function __construct(
RequestSerializerInterface $serializer = null,
ResponseReaderInterface $reader = null
?RequestSerializerInterface $serializer = null,
?ResponseReaderInterface $reader = null
) {
$this->setRequestSerializer($serializer ?: new RequestSerializer());
$this->setResponseReader($reader ?: new ResponseReader());
+2 -2
View File
@@ -28,9 +28,9 @@ class Consumer extends AbstractConsumer
/**
* @param ClientInterface $client Client instance used by the consumer.
* @param array $options Options for the consumer initialization.
* @param array|null $options Options for the consumer initialization.
*/
public function __construct(ClientInterface $client, array $options = null)
public function __construct(ClientInterface $client, ?array $options = null)
{
$this->checkCapabilities($client);
+2 -2
View File
@@ -49,9 +49,9 @@ class MultiExec implements ClientContextInterface
/**
* @param ClientInterface $client Client instance used by the transaction.
* @param array $options Initialization options.
* @param array|null $options Initialization options.
*/
public function __construct(ClientInterface $client, array $options = null)
public function __construct(ClientInterface $client, ?array $options = null)
{
$this->assertClient($client);
+2 -2
View File
@@ -74,7 +74,7 @@ abstract class PredisTestCase extends \PHPUnit\Framework\TestCase
*
* @return RedisCommandConstraint
*/
public function isRedisCommand($command = null, array $arguments = null): RedisCommandConstraint
public function isRedisCommand($command = null, ?array $arguments = null): RedisCommandConstraint
{
return new RedisCommandConstraint($command, $arguments);
}
@@ -243,7 +243,7 @@ abstract class PredisTestCase extends \PHPUnit\Framework\TestCase
*
* @return Client
*/
protected function createClient(array $parameters = null, array $options = null, ?bool $flushdb = true): Client
protected function createClient(?array $parameters = null, ?array $options = null, ?bool $flushdb = true): Client
{
$parameters = array_merge(
$this->getDefaultParametersArray(),
+1 -1
View File
@@ -25,7 +25,7 @@ class RedisCommandConstraint extends \PHPUnit\Framework\Constraint\Constraint
* @param string|CommandInterface $command Expected command instance or command ID
* @param ?array $arguments Expected command arguments
*/
public function __construct($command, array $arguments = null)
public function __construct($command, ?array $arguments = null)
{
if ($command instanceof CommandInterface) {
$this->commandID = strtoupper($command->getId());
+1 -1
View File
@@ -325,7 +325,7 @@ class PredisStrategyTest extends PredisTestCase
*
* @return array
*/
protected function getExpectedCommands(string $type = null): array
protected function getExpectedCommands(?string $type = null): array
{
$commands = [
/* commands operating on the key space */
+1 -1
View File
@@ -348,7 +348,7 @@ class RedisStrategyTest extends PredisTestCase
*
* @return array
*/
protected function getExpectedCommands(string $type = null): array
protected function getExpectedCommands(?string $type = null): array
{
$commands = [
/* commands operating on the key space */
+1 -1
View File
@@ -123,7 +123,7 @@ class CommunicationExceptionTest extends PredisTestCase
Connection\NodeConnectionInterface $connection,
string $message,
int $code = 0,
Exception $inner = null
?Exception $inner = null
) {
return $this->getMockBuilder('Predis\CommunicationException')
->setConstructorArgs([$connection, $message, $code, $inner])
@@ -26,7 +26,7 @@ class ConnectionExceptionTest extends CommunicationExceptionTest
NodeConnectionInterface $connection,
string $message,
int $code = 0,
Exception $inner = null
?Exception $inner = null
) {
return new ConnectionException($connection, $message, $code, $inner);
}
@@ -1530,7 +1530,7 @@ class SentinelReplicationTest extends PredisTestCase
*
* @return SentinelReplication
*/
protected function getReplicationConnection(string $service, array $sentinels, Connection\FactoryInterface $factory = null): SentinelReplication
protected function getReplicationConnection(string $service, array $sentinels, ?Connection\FactoryInterface $factory = null): SentinelReplication
{
$factory = $factory ?: new Connection\Factory();
@@ -28,7 +28,7 @@ class ProtocolExceptionTest extends CommunicationExceptionTest
NodeConnectionInterface $connection,
string $message,
int $code = 0,
Exception $inner = null
?Exception $inner = null
): CommunicationException {
return new ProtocolException($connection, $message, $code, $inner);
}
@@ -390,7 +390,7 @@ class ReplicationStrategyTest extends PredisTestCase
*
* @return array
*/
protected function getExpectedCommands(string $type = null): array
protected function getExpectedCommands(?string $type = null): array
{
$commands = [
/* commands operating on the connection */