geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-09-11 19:07:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

use a loop instead of recursion in CursorBasedIterator

Browse Source 
servers with large sets of keys will cause memory and stack exhaustion if recursion is used
This commit is contained in:
Gwilym Evans
2014-06-26 12:55:01 +10:00
parent 4db00173f3
commit f05cb1b46d
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Predis/Collection/Iterator/CursorBasedIterator.php
+14 -10
View File
@@ -165,17 +165,21 @@ abstract class CursorBasedIterator implements Iterator
*/
public function next()
{
if (!$this->elements && $this->fetchmore) {
$this->fetch();
}
do {
$more = false;
if ($this->elements) {
$this->extractNext();
} elseif ($this->cursor) {
$this->next();
} else {
$this->valid = false;
}
if (!$this->elements && $this->fetchmore) {
$this->fetch();
}
if ($this->elements) {
$this->extractNext();
} elseif ($this->cursor) {
$more = true;
} else {
$this->valid = false;
}
} while ($more);
}
/**