geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-08-30 12:15:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] Troubles with HHVM <= 3.6.6 and float timeouts.

Browse Source 
HHVM is still being used by Travis CI but this bug makes the build to
take 14 minutes to complete, which is unacceptable.
This commit is contained in:
Daniele Alessandri
2016-05-30 16:42:20 +02:00
parent 5850029f89
commit f6bf2b5977
1 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PHPUnit/PredisConnectionTestCase.php
+18 -14
View File
@@ -116,18 +116,6 @@ abstract class PredisConnectionTestCase extends PredisTestCase
$this->assertEquals($parameters, $unserialized->getParameters());
}
/**
* @group disconnected
* @group slow
* @expectedException \Predis\Connection\ConnectionException
*/
public function testThrowExceptionWhenUnableToConnect()
{
$parameters = array('host' => '169.254.10.10', 'timeout' => 0.5);
$connection = $this->createConnectionWithParams($parameters, false);
$connection->executeCommand($this->getCurrentProfile()->createCommand('ping'));
}
// ******************************************************************** //
// ---- INTEGRATION TESTS --------------------------------------------- //
// ******************************************************************** //
@@ -448,9 +436,17 @@ abstract class PredisConnectionTestCase extends PredisTestCase
*/
public function testThrowsExceptionOnConnectionTimeout()
{
// TODO: float timeouts for connect() under HHVM 3.6.6 are broken and,
// unfortunately, this is the version still being used by Travis CI.
if (defined('HHVM_VERSION') && version_compare(HHVM_VERSION, '3.6.6', '<=')) {
$timeout = 1;
} else {
$timeout = 0.1;
}
$connection = $this->createConnectionWithParams(array(
'host' => '169.254.10.10',
'timeout' => 0.1,
'timeout' => $timeout,
), false);
$connection->connect();
@@ -464,9 +460,17 @@ abstract class PredisConnectionTestCase extends PredisTestCase
*/
public function testThrowsExceptionOnConnectionTimeoutIPv6()
{
// TODO: float timeouts for connect() under HHVM 3.6.6 are broken and,
// unfortunately, this is the version still being used by Travis CI.
if (defined('HHVM_VERSION') && version_compare(HHVM_VERSION, '3.6.6', '<=')) {
$timeout = 1;
} else {
$timeout = 0.1;
}
$connection = $this->createConnectionWithParams(array(
'host' => '0:0:0:0:0:ffff:a9fe:a0a',
'timeout' => 0.1,
'timeout' => $timeout,
), false);
$connection->connect();