* Be sure that position always have type integer
* Annotate properly return types for SPL interfaces implementation
It is allows avoiding deprecation messages from `symfony/error-handler` like a '[info] User Deprecated: Method "Iterator::rewind()" might add "void" as a native return type declaration in the future. Do the same in implementation "Predis\Collection\Iterator\CursorBasedIterator" now to avoid errors or add an explicit @return annotation to suppress this message.'
Fixed via `symfony/error-handler` patch script: ` SYMFONY_PATCH_TYPE_DECLARATIONS="force=phpdoc&php=5.3" ./vendor/bin/patch-type-declarations` and some additional manual work
Some details about why this is necessary and how checks with trigger deprecations works: https://wouterj.nl/2021/09/symfony-6-native-typing
* Add clear method to pipeline
Ability to clean pipeline and responses when reusing pipelines.
Allows pipeline to be executed using chunks without out-of-control
increase in memory usage.
* spacing
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
* throw exception if connection->read() returns an error object in consumer
* Add test case for Consumer throwing a ServerException when no subscription could be established
* spacing
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
* Fix PHP 8.1 strlen breakage
This adds a fallback to an empty string if the argument is `null` for some reason.
* Update StreamConnection.php
* use `strval()`
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
$this->retryWait is in milliseconds. It's setter misleadingly document it as seconds.
Fixing by renaming the argument variable name without altering the functionality.
The patches to get PHPUnit working are causing problems for other projects that use both `cweagans/composer-patch-installers` and `predis/predis` along with PHPUnit.
This change moves the patch application to a simple PHP script run on the `post-update-cmd` composer event and removes the dependency on the patch installers package.
When using the phpiredis-based connection backends, failed pipelines led
to spurious responses returned after reconnecting to Redis because the
underlying reader was not properly reset by discarding buffered replies
after disconnecting.
Fixes a couple of issues reported in #363.
Authentication for sentinels was implemented in v1.1.5 (commit 2e76410)
but ended up being bugged (see ISSUE #658). This is now postponed as it
requires a more thorough investigation.
Password-based authentication for sentinels has been added in Redis 5.
Predis was actively ignoring any "password" parameter for sentinels when
creating connections to them to avoid issues when this parameter is set
in the default "parameters" array passed via client options, as they are
applied to **every** connection created by Predis (see #346).
We need to find a better way to specify a common password for sentinels
to be handled in a different way than the ones for Redis nodes. For now
each sentinel node protected by password must have an explicit password
set in its parameters list even if this password, by design, is the same
for all sentinels. Since we cannot use default "parameters" as explained
above but we still need to pass a common value for all sentinels an idea
could be using a dedicated client option like we did with "service", but
we will see later.
In this commit we also explicitly reset any "username" parameter as it
would trigger an `AUTH $username $password` but sentinels do not support
ACL authentication.
Fixes#594.
Nicolas Grekas
Till Krüss
Stefano Borghi
angeljqv
Andrii Dembitskyi
Karol Hrusza
Julian Haupt
Ondřej Ešler
fluffycondor
Till Krüss
Pim Jansen
kgasienica
Dries Vints
Vadim Borodavko
John Paul E. Balandan, CPA
Alexander M. Turek
Nick Doulgeridis
Remi Collet
Pitchaya Boonsarngsuk
Robert O'Rourke
Robert O'Rourke
Daniele Alessandri
Qusonann