mirror of
https://github.com/predis/predis.git
synced 2026-08-20 09:25:58 +00:00
Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| f76d616d57 | |||
| c41bb2c314 | |||
| d4fb7d9143 |
@@ -1,3 +1,8 @@
|
||||
v0.6.5 (2011-02-12)
|
||||
* FIX: due to an untested internal change introduced in v0.6.4, a wrong
|
||||
handling of bulk reads of zero-length values was producing protocol
|
||||
desynchronization errors (ISSUE #20).
|
||||
|
||||
v0.6.4 (2011-02-12)
|
||||
* Various performance improvements (15% ~ 25%) especially when dealing with
|
||||
long multibulk replies or when using clustered connections.
|
||||
|
||||
+1
-1
@@ -578,7 +578,7 @@ class ResponseBulkHandler implements IResponseHandler {
|
||||
));
|
||||
}
|
||||
if ($length >= 0) {
|
||||
return $length > 0 ? substr($connection->readBytes($length + 2), 0, -2) : '';
|
||||
return substr($connection->readBytes($length + 2), 0, -2);
|
||||
}
|
||||
if ($length == -1) {
|
||||
return null;
|
||||
|
||||
@@ -381,6 +381,12 @@ class PredisClientFeaturesTestSuite extends PHPUnit_Framework_TestCase {
|
||||
});
|
||||
}
|
||||
|
||||
function testResponseReader_EmptyBulkResponse() {
|
||||
$this->assertTrue($this->redis->set('foo', ''));
|
||||
$this->assertEquals('', $this->redis->get('foo'));
|
||||
$this->assertEquals('', $this->redis->get('foo'));
|
||||
}
|
||||
|
||||
|
||||
/* Client + CommandPipeline */
|
||||
|
||||
|
||||
@@ -89,8 +89,11 @@ class RedisCommandTestSuite extends PHPUnit_Framework_TestCase {
|
||||
|
||||
function testGet() {
|
||||
$this->redis->set('foo', 'bar');
|
||||
|
||||
$this->assertEquals('bar', $this->redis->get('foo'));
|
||||
|
||||
$this->assertTrue($this->redis->set('foo', ''));
|
||||
$this->assertEquals('', $this->redis->get('foo'));
|
||||
|
||||
$this->assertNull($this->redis->get('fooDoesNotExist'));
|
||||
|
||||
// should throw an exception when trying to do a GET on non-string types
|
||||
|
||||
Reference in New Issue
Block a user