geckon01/simple-php-router
1
0
Fork 0
mirror of https://github.com/skipperbent/simple-php-router.git synced 2026-07-11 12:42:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #316 from skipperbent/v3

Browse Source 
V3
This commit is contained in:
Simon Sessingø
2017-11-25 01:35:03 +01:00
committed by GitHub
parent 2472079642 496d3e7182
commit 0b8931a2e1
2 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
README.md
+13 -7
View File
@@ -212,17 +212,23 @@ Simply create a new `web.config` file in your projects `public` directory and pa
</configuration> </configuration>
``` ```
#### Troubleshoting #### Troubleshooting
If you do not have a favicon.ico file in your project, you can get `404 Router::notFoundException()` constantly. If you do not have a `favicon.ico` file in your project, you can get a `NotFoundHttpException` (404 - not found).
To add `favicon.ico` as exception, you can add this line to the `<conditions>` group: To add `favicon.ico` to the IIS ignore-list, add the following line to the `<conditions>` group:
```<add input="{REQUEST_FILENAME}" negate="true" pattern="favicon.ico" ignoreCase="true" />``` ```
<add input="{REQUEST_FILENAME}" negate="true" pattern="favicon.ico" ignoreCase="true" />
```
You can also make one exception for files with some extensions: You can also make one exception for files with some extensions:
```<add input="{REQUEST_FILENAME}" pattern="\.ico|\.png|\.css|\.jpg" negate="true" ignoreCase="true" />``` ```
<add input="{REQUEST_FILENAME}" pattern="\.ico|\.png|\.css|\.jpg" negate="true" ignoreCase="true" />
```
If you are using `$_SERVER['ORIG_PATH_INFO']`, you will get `\index.php\` as part of the returned value. By sample: If you are using `$_SERVER['ORIG_PATH_INFO']`, you will get `\index.php\` as part of the returned value. For example:
```/index.php/test/mypage.php``` ```
/index.php/test/mypage.php
```
### Configuration ### Configuration
src/Pecee/SimpleRouter/SimpleRouter.php
+1 -1
View File
@@ -427,7 +427,7 @@ class SimpleRouter
$callback = $route->getCallback(); $callback = $route->getCallback();
/* Only add default namespace on relative callbacks */ /* Only add default namespace on relative callbacks */
if ($callback === null || $callback[0] !== '\\') { if ($callback === null || (is_string($callback) === true && $callback[0] !== '\\')) {
$namespace = static::$defaultNamespace; $namespace = static::$defaultNamespace;