geckon01/whoops
1
0
Fork 0
mirror of https://github.com/filp/whoops.git synced 2026-09-15 20:26:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #347 from filp/fix-flaky-plain-text-tests

Browse Source 
Fix flaky PlainTextHandler tests by replacing exact matching of strings
This commit is contained in:
Denis Sokolov
2015-12-12 22:38:23 +02:00
parent b0a29b3eac 4cbf3a8bda
commit e9def68b76
1 changed files with 13 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Whoops/Handler/PlainTextHandlerTest.php
+13 -17
View File
@@ -229,13 +229,11 @@ class PlainTextHandlerTest extends TestCase
$loggerOnly = false
);
$lines = explode("\n", $text);
// Check that the response has the correct value:
$this->assertEquals('Stack trace:', $lines[1]);
$this->assertContains('Stack trace:', $text);
// Check that the trace is returned:
$this->assertEquals(
$this->assertContains(
sprintf(
'%3d. %s->%s() %s:%d',
2,
@@ -244,7 +242,7 @@ class PlainTextHandlerTest extends TestCase
__FILE__,
55
),
$lines[3]
$text
);
}
@@ -271,10 +269,10 @@ class PlainTextHandlerTest extends TestCase
$this->assertGreaterThan(60, count($lines));
// Check that the response has the correct value:
$this->assertEquals('Stack trace:', $lines[1]);
$this->assertContains('Stack trace:', $text);
// Check that the trace is returned:
$this->assertEquals(
$this->assertContains(
sprintf(
'%3d. %s->%s() %s:%d',
2,
@@ -283,15 +281,15 @@ class PlainTextHandlerTest extends TestCase
__FILE__,
55
),
$lines[8]
$text
);
// Check that the trace arguments are returned:
$this->assertEquals(sprintf(
$this->assertContains(sprintf(
'%s string(%d) "%s"',
PlainTextHandler::VAR_DUMP_PREFIX,
strlen('test message'),
'test message'
), $lines[5]
), $text
);
}
@@ -312,13 +310,11 @@ class PlainTextHandlerTest extends TestCase
$loggerOnly = false
);
$lines = explode("\n", $text);
// Check that the response has the correct value:
$this->assertEquals('Stack trace:', $lines[1]);
$this->assertContains('Stack trace:', $text);
// Check that the trace is returned:
$this->assertEquals(
$this->assertContains(
sprintf(
'%3d. %s->%s() %s:%d',
2,
@@ -327,16 +323,16 @@ class PlainTextHandlerTest extends TestCase
__FILE__,
55
),
$lines[8]
$text
);
// Check that the trace arguments are returned:
$this->assertEquals(sprintf(
$this->assertContains(sprintf(
'%s string(%d) "%s"',
PlainTextHandler::VAR_DUMP_PREFIX,
strlen('test message'),
'test message'
), $lines[5]
), $text
);
}