Test for #317

.github/workflows/static-analysis.yml

@@ -3,6 +3,7 @@ name: static analysis
 on:
   push:
     branches:
+      - master
       - '*.x'
   pull_request:
 

.github/workflows/tests.yml

@@ -1,10 +1,13 @@
-name: unit-tests
+name: build
 
 on:
   push:
     branches:
+      - master
       - '*.x'
   pull_request:
+  schedule:
+    - cron: '0 0 * * *'
 
 jobs:
   tests:
@@ -45,6 +48,13 @@ jobs:
       - name: Execute tests
         run: vendor/bin/phpunit --coverage-clover build/logs/clover.xml --exclude-group flaky
 
+      - name: Coverage
+        if: ${{ matrix.php == '8.1' && matrix.deps == 'lowest' }}
+        shell: bash
+        env:
+          CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
+        run: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r build/logs/clover.xml
+
       - name: Store artifacts
         if: ${{ matrix.php == '8.1' && matrix.deps == 'lowest' }}
         uses: actions/upload-artifact@v4

.github/workflows/upload-to-codacy.yml

@@ -1,33 +0,0 @@
-name: upload-coverage-to-codacy
-on:
-  workflow_run:
-    workflows: ["unit-tests"]
-    types:
-      - completed
-
-jobs:
-  upload:
-    runs-on: ubuntu-latest
-    if: >
-      github.event.workflow_run.event == 'pull_request' &&
-      github.event.workflow_run.conclusion == 'success'
-    strategy:
-      fail-fast: true
-    name: upload-coverage
-    
-    steps:
-      - name: Setup logs directory
-        run: mkdir -p build/coverage
-      - name: Download clover.xml artifact
-        uses: dawidd6/action-download-artifact@v7
-        with:
-          workflow: tests.yml
-          name: clover.xml
-          path: build/coverage
-
-      - name: Upload Coverage to Codacy
-        shell: bash
-        env:
-          CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
-
-        run: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r build/coverage/clover.xml

README.md

@@ -34,7 +34,7 @@ This library aims to support RFCs:
 * [Spoofchecking](/src/Validation/Extra/SpoofCheckValidation.php) and
 [DNSCheckValidation](/src/Validation/DNSCheckValidation.php) validation
 requires that your PHP system has the
-[PHP Internationalization Libraries](https://php.net/manual/en/book.intl.php)
+[PHP Internationalization Libraries](https://php.net/manual/en/book.intl.php) 
 (also known as PHP Intl)
 
 **Note**: `PHP version upgrades will happen to accomodate to the pace of major
@@ -109,6 +109,7 @@ Validations not present in the RFCs
 1. [SpoofCheckValidation](/src/Validation/Extra/SpoofCheckValidation.php): 
 Will check for multi-utf-8 chars that can signal an erroneous email name.
 
+
 ### How to extend
 
 It's easy! You just need to implement
@@ -125,8 +126,7 @@ Is short and simple and will help a lot.
 (You can find current contributors
 [here](https://github.com/egulias/EmailValidator/graphs/contributors))
 
-As this is a port from another library and work, here are other people related
-to the previous one:
+As this is a port from another library and work, here are other people related to the previous one:
 
 * Ricard Clau [@ricardclau](https://github.com/ricardclau):
 Performance against PHP built-in filter_var (v2 and earlier)

src/Parser/LocalPart.php

@@ -34,7 +34,6 @@ class LocalPart extends PartParser
 
     public function parse(): Result
     {
-        $this->lexer->clearRecorded();
         $this->lexer->startRecording();
 
         while (!$this->lexer->current->isA(EmailLexer::S_AT) && !$this->lexer->current->isA(EmailLexer::S_EMPTY)) {

src/Result/Reason/NoDNSRecord.php

@@ -11,6 +11,6 @@ class NoDNSRecord implements Reason
 
     public function description() : string
     {
-        return 'No MX or A DNS record was found for this email';
+        return 'No MX or A DSN record was found for this email';
     }
 }

src/Result/Result.php

@@ -6,26 +6,22 @@ interface Result
 {
     /**
      * Is validation result valid?
-     * 
      */
-    public function isValid(): bool;
+    public function isValid() : bool;
 
     /**
      * Is validation result invalid?
      * Usually the inverse of isValid()
-     * 
      */
-    public function isInvalid(): bool;
+    public function isInvalid() : bool;
 
     /**
      * Short description of the result, human readable.
-     * 
      */
-    public function description(): string;
+    public function description() : string;
 
     /**
      * Code for user land to act upon.
-     * 
      */
-    public function code(): int;
+    public function code() : int;
 }

tests/EmailValidator/EmailParserTest.php

@@ -28,18 +28,4 @@ class EmailParserTest extends TestCase
         $this->assertEquals($local, $parser->getLocalPart());
         $this->assertEquals($domain, $parser->getDomainPart());
     }
-
-    public function testMultipleEmailAddresses()
-    {
-        $parser = new EmailParser(new EmailLexer());
-        $parser->parse('some-local-part@some-random-but-large-domain-part.example.com');
-
-        $this->assertSame('some-local-part', $parser->getLocalPart());
-        $this->assertSame('some-random-but-large-domain-part.example.com', $parser->getDomainPart());
-
-        $parser->parse('another-local-part@another.example.com');
-
-        $this->assertSame('another-local-part', $parser->getLocalPart());
-        $this->assertSame('another.example.com', $parser->getDomainPart());
-    }
 }