Compare commits

..

6 Commits

Author SHA1 Message Date
Eduardo Gulias Davis 9ede2f8795 polish 2024-12-27 23:42:49 +01:00
Eduardo Gulias Davis 013f386b49 polish 2024-12-27 23:24:59 +01:00
Eduardo Gulias Davis 2d5d7a034a Fix action usage 2024-12-27 23:24:59 +01:00
Eduardo Gulias Davis 2f210503cd improve workflow 2024-12-27 23:24:58 +01:00
Eduardo Gulias Davis d2580184a4 polish 2024-12-27 23:13:48 +01:00
Eduardo Gulias Davis f31e565efd Polish 2024-12-27 22:56:31 +01:00
4 changed files with 3 additions and 21 deletions
+2 -5
View File
@@ -8,9 +8,6 @@ on:
jobs:
upload:
runs-on: ubuntu-latest
if: >
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.conclusion == 'success'
strategy:
fail-fast: true
name: upload-coverage
@@ -18,10 +15,10 @@ jobs:
steps:
- name: Setup logs directory
run: mkdir -p build/coverage
- name: Download clover.xml artifact
uses: dawidd6/action-download-artifact@v7
uses: actions/download-artifact@v3
with:
workflow: tests.yml
name: clover.xml
path: build/coverage
-1
View File
@@ -34,7 +34,6 @@ class LocalPart extends PartParser
public function parse(): Result
{
$this->lexer->clearRecorded();
$this->lexer->startRecording();
while (!$this->lexer->current->isA(EmailLexer::S_AT) && !$this->lexer->current->isA(EmailLexer::S_EMPTY)) {
+1 -1
View File
@@ -11,6 +11,6 @@ class NoDNSRecord implements Reason
public function description() : string
{
return 'No MX or A DNS record was found for this email';
return 'No MX or A DSN record was found for this email';
}
}
-14
View File
@@ -28,18 +28,4 @@ class EmailParserTest extends TestCase
$this->assertEquals($local, $parser->getLocalPart());
$this->assertEquals($domain, $parser->getDomainPart());
}
public function testMultipleEmailAddresses()
{
$parser = new EmailParser(new EmailLexer());
$parser->parse('some-local-part@some-random-but-large-domain-part.example.com');
$this->assertSame('some-local-part', $parser->getLocalPart());
$this->assertSame('some-random-but-large-domain-part.example.com', $parser->getDomainPart());
$parser->parse('another-local-part@another.example.com');
$this->assertSame('another-local-part', $parser->getLocalPart());
$this->assertSame('another.example.com', $parser->getDomainPart());
}
}