:octocat: QRCode::isByte(): string "0" fails with empty()

This commit is contained in:
smiley
2022-07-25 11:04:58 +02:00
parent a614d1e192
commit de3dd9a480
2 changed files with 2 additions and 1 deletions
+1 -1
View File
@@ -307,7 +307,7 @@ class QRCode{
* a dummy
*/
public function isByte(string $data):bool{
return !empty($data);
return $data !== '';
}
}
+1
View File
@@ -74,6 +74,7 @@ class QRCodeTest extends TestCase{
public function testIsByte():void{
$this::assertTrue($this->qrcode->isByte("\x01\x02\x03"));
$this::assertTrue($this->qrcode->isByte(' ')); // not empty!
$this::assertTrue($this->qrcode->isByte('0'));
$this::assertFalse($this->qrcode->isByte(''));
}